Implement MSTest v4 analyzer suggestions: parallelization, assertion order, and specific assertions

[Copilot]

MSTest v4.x ships with analyzers that flag 7 issues across the test project — argument order violations (MSTEST0017), generic assertions where specific ones exist (MSTEST0037), and missing explicit parallelization config (MSTEST0001).

Changes

AssemblyInfo.cs — MSTEST0001

Added explicit parallelization configuration:

[assembly: Parallelize(Workers = 4, Scope = ExecutionScope.MethodLevel)]

StrongDictionaryTests.cs — MSTEST0017 + MSTEST0037

• Fixed swapped expected/actual arguments on lines 59 and 72
• Replaced Assert.AreEqual(5, collection.Count) → Assert.HasCount(5, collection) (line 18)
• Replaced Assert.AreNotEqual(null, obj) → Assert.IsNotNull(obj) (lines 100, 110)

String_ExtensionsTests.cs — MSTEST0017

• Fixed swapped expected/actual argument order (line 55)

Result

Build produces 0 MSTEST warnings; all 21 tests pass at 100%.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Implement MSTest v4 code quality analyzer suggestions</issue_title>
<issue_description>## Overview
MSTest v4 introduces enhanced code analyzers that provide 7 actionable suggestions to improve test code quality. These are currently appearing as warnings but represent opportunities to enhance test maintainability and diagnostic clarity.

Current Status

• MSTest packages successfully upgraded to v4.0.2
• All 21 tests passing (100% success rate)
• 7 analyzer warnings present (not errors)

Analyzer Warnings to Address

1. MSTEST0001: Configure Test Parallelization (1 instance)

Location: Assembly level
Current: Tests run sequentially by default (no explicit configuration)
Recommendation: Add explicit parallelization configuration

Suggested Fix:

// Add to RESTRunner.Domain.Tests/GlobalUsings.cs or AssemblyInfo.cs
[assembly: Parallelize(Workers = 0, Scope = ExecutionScope.ClassLevel)]

Benefit: Explicitly documents parallelization strategy, enables future optimization

---

2. MSTEST0017: Fix Assertion Argument Order (3 instances)

Locations:

• StrongDictionaryTests.cs line 59
• StrongDictionaryTests.cs line 72
• String_ExtensionsTests.cs line 55

Issue: Expected and actual arguments are swapped, leading to confusing error messages

Example of Current (Incorrect) Pattern:

// WRONG - arguments swapped
Assert.AreEqual(actualValue, expectedValue);

Correct Pattern:

// CORRECT - expected first, actual second
Assert.AreEqual(expectedValue, actualValue);

Benefit: Better error messages when tests fail - clearly shows expected vs actual values

---

3. MSTEST0037: Use Specific Assertion Methods (3 instances)

Locations:

• StrongDictionaryTests.cs line 18: Use Assert.HasCount instead of Assert.AreEqual
• StrongDictionaryTests.cs line 100: Use Assert.IsNotNull instead of Assert.AreNotEqual
• StrongDictionaryTests.cs line 110: Use Assert.IsNotNull instead of Assert.AreNotEqual

Current Pattern:

// Less specific
Assert.AreEqual(5, collection.Count);
Assert.AreNotEqual(null, obj);

Improved Pattern:

// More specific and descriptive
Assert.HasCount(5, collection);
Assert.IsNotNull(obj);

Benefit: More descriptive test failures, clearer intent, better IDE integration

---

Implementation Plan

Phase 1: Assembly-Level Configuration (5 minutes)

1. Create or update AssemblyInfo.cs in RESTRunner.Domain.Tests
2. Add [assembly: Parallelize(...)] attribute
3. Document parallelization strategy in comments
4. Build and verify no test failures

Phase 2: Fix Assertion Argument Order (10-15 minutes)

1. Open StrongDictionaryTests.cs
   • Line 59: Swap arguments in Assert.AreEqual
   • Line 72: Swap arguments in Assert.AreEqual
2. Open String_ExtensionsTests.cs
   • Line 55: Swap arguments in Assert.AreEqual
3. Run tests to verify all still pass
4. Intentionally break a test to verify error message improvement

Phase 3: Update to Specific Assertions (10-15 minutes)

1. Open StrongDictionaryTests.cs
   • Line 18: Replace Assert.AreEqual(count, dict.Count) with Assert.HasCount(count, dict)
   • Line 100: Replace Assert.AreNotEqual(null, obj) with Assert.IsNotNull(obj)
   • Line 110: Replace Assert.AreNotEqual(null, obj) with Assert.IsNotNull(obj)
2. Run tests to verify all still pass
3. Review improved test readability

Phase 4: Validation (5 minutes)

1. Build solution: dotnet build --configuration Release
2. Run all tests: dotnet test
3. Verify 0 MSTEST warnings remain
4. Commit changes with descriptive message

---

Acceptance Criteria

• All 7 MSTest v4 analyzer warnings resolved
• All 21 tests still passing (100%)
• Build produces 0 MSTEST warnings
• Test failure messages are clearer (verify with intentional break)
• Code committed with clear commit message
• No regressions in test functionality

---

Benefits

1. Better Diagnostics: Clearer test failure messages
2. Code Clarity: More explicit and descriptive assertions
3. Future Performance: Foundation for test parallelization optimization
4. Best Practices: Aligns with MSTest v4 recommendations
5. Maintainability: Easier for future developers to understand test intent

---

Estimated Effort

Total Time: 30-60 minutes
Complexity: Low
Risk: Very Low (all tests currently passing)

---

Related

• PR: Upgrade to .NET 10 with package optimization
• MSTest v4 Documentation: https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers

---

Notes

• All warnings are suggestions, not errors
• Tests function correctly without these changes
• Changes improve code quality and main...

• Fixes Implement MSTest v4 code quality analyzer suggestions #2

---

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

[markhazleton]

ok