test: cover IVF remote stream lifecycle regressions - #28672
Draft
VioletQwQ-0 wants to merge 3 commits into
Draft
Conversation
Collaborator
Author
|
Addressed the P2 connection-cancellation oracle gap in follow-up commit The Validation after the edit:
The BVT plan-path enhancement remains a non-blocking follow-up; this change addresses the blocking P2 only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #28378
What this PR does / why we need it:
Add regression coverage for queued stream cancellation, shuffle receiver retirement, and distributed IVF query cleanup. Production fixes are already present through #28358, the relevant dispatch/remote pipeline changes in #28364, and #28539; this PR changes tests only and does not establish their individual causal contribution to the original TKE incident.
test/distributed/cases/vector/vector_ivf_multicn_search.sqland.resultwith cosine, raw-vector IP/normalized-query, empty-result, and follow-up checks. The GROUP_CONCAT metadata expectation uses the existing server TEXT mapping and Connector/J 8.0.15 metadata; results were not regenerated blindly.Validation (final file contents include the follow-up assertion fix; commits
231239efba5eca40bde92ed3932d44aa4ffc3bbaand4e6fe7b3049ba2c6a4808c2f6130dab61851a072, product base2a6fe7f61358e846a20aafba3b50903a61608682):TestRemoteNotifyCancellationReleasesCreditWaitAndRegistrationpassed ordinary 100 iterations and race 20 iterations after asserting that connection cancellation closesproc.Ctx, records a non-nilErrStreamClosedcause, and preserves it through repeated terminal cleanup../pkg/sql/compilepackage passed once under the race detector; no race report was emitted.TestIssue28313EmptyRemoteDispatchandTestIssue28378IVFFlatRemoteLifecycle: one ordinary and one race run passed, including injected preparation failure and the full IVF workload.Deployment evidence for the already-fixed product base, independently of this new test commit:
QA required: yes — distributed timing and deployed-workload acceptance. Automated terminal coverage includes completed SQL assertions, cancellation waiter exit, preserved terminal errors, registration removal, and cleanup. QA should review the target release's inclusion of the existing production fixes and the attached run evidence. First-error query/stream/peer correlation and unique root-cause attribution remain unavailable; this PR must not auto-close #28378.