Skip to content

ILL_SALSA fix linter and add n reflections to parameters#2572

Merged
mads-bertelsen merged 3 commits into
mainfrom
mono_bent_fix_linter_and_add_n_reflections_to_parameters
Jul 17, 2026
Merged

ILL_SALSA fix linter and add n reflections to parameters#2572
mads-bertelsen merged 3 commits into
mainfrom
mono_bent_fix_linter_and_add_n_reflections_to_parameters

Conversation

@Lomholy

@Lomholy Lomholy commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Free-form text area

Please describe what your PR is adding in terms of features or bugfixes:
Fixes ILL_SALSA emitting linter errors #2096, adds a link in the header of monochromator bent to the article on the component, and finally moves the MAX_REFLECTIONS variable, to the parameters of the component as n_reflections.


Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
OS Tahoes 26.5.2


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes patches to an existing component file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)
    • I have ensured that basic use of the component is OK (e.g. an instrument using it compiles?)
    • I have used the mctest utility to test one or more instruments making use of the component (please attach mcviewtest report as screenshot in comments)
    • I have used the mccode-clangformat tool to apply the standard McCode component indentation scheme
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised
  • My contribution includes patches to an existing instrument file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)
    • I have used the mctest utility to test the instrument (please attach mcviewtest report as screenshot in comments)
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised

@Lomholy

Lomholy commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

mctest screenshot:
image
mcdoc screenshots:
image
image
image

@mads-bertelsen

Copy link
Copy Markdown
Contributor

Looks great, quite small safe updates, will merge

@mads-bertelsen
mads-bertelsen merged commit acdbb85 into main Jul 17, 2026
20 checks passed
@Lomholy
Lomholy deleted the mono_bent_fix_linter_and_add_n_reflections_to_parameters branch July 17, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants