Report invalid selectors without panicking - #87
Open
VrtxOmega wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65.
Problem
Unsupported CSS selectors such as
div:has(h1)make htmlq panic while parsing the selector. The CLI exits 101 and can emit a Rust backtrace instead of a user-facing error.Change
Handle the selector parser error explicitly, print the exact invalid selector, and exit with status 2.
This does not add
:hassupport or change successful selector behavior.Verification
mastercargo test --all-targets— 10 passed, 0 faileddivselector check — output unchangedRisk
Low. The change affects only selector-parse failures and adds no dependency.