feat: new -distroless variant based on the new DHI image#354
Open
mathieu-benoit wants to merge 3 commits into
Open
feat: new -distroless variant based on the new DHI image#354mathieu-benoit wants to merge 3 commits into
-distroless variant based on the new DHI image#354mathieu-benoit wants to merge 3 commits into
Conversation
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
mathieu-benoit
changed the title
-distroless variant based on the new DHI image
Harsh4902
added
kind/feature
Member
|
Thanks @mathieu-benoit for this PR. I'll wait until you say |
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
Contributor
Author
|
Hi @Harsh4902 and team, this is now ready for your review please, thanks! I tried to document as much as I can to show the diffs between the before and after, even if this PR is about adding a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
-distrolessvariant (based on DHI images), implementation for #298.tl,dr - With DHI it's:
distroless(no unnecessary package manager,bash,curl, etc.)Notes:
USERis changing from1001to65532(still non-root user)alpinewas chosen here, just for your informationdebianflavor exists.alpineallows to get a smaller footprint, especially for this CLI component.dhi.io/golang:1.25.10already exists and could fix more CVEs, but want to keep this PR with1.25.9for now to compare apples and apples between the before and after. Once this one is merged, Dependabot will anyway bump1.25.9to1.25.10.Tested these successfully:
docker run --rm -it microcks-cli:dhi microcks version docker run --rm -it microcks-cli:dhi microcks helpImportant: I encourage the reviewers to conduct more tests with this new container image.
This is saving ~150MB on disk locally:
Summary of the diff by running
docker scout compare --to microcks-cli:before microcks-cli:dhi:Here below are all the details showing the diffs between before and after.
Environment Variables
Labels
Config
Packages and Vulnerabilities