Fix manual json return#378
Open
Manar-Elhabbal7 wants to merge 2 commits into
Open
Conversation
0b4f441 to
2bc6ca5
Compare
…ing in CreateTestResult Signed-off-by: Manar Elhabbal <manarelhabbal619@gmail.com>
2bc6ca5 to
1d4a285
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves how the
CreateTestResult()request payload is built by replacing manual JSON string concatenation with a structured approach using Go structs andjson.Marshal().Previously, building the JSON manually could lead to issues when values contained special characters like quotes or backslashes. This refactor makes the request generation safer and more reliable.
What changed
Impact
before solving it
after solving it
Related issue(s) : #377