Fix: stale my/ paths in skill docs (bulk migration)

[saengland]

Description

Migrates 159 stale my/ path references across 40 files to the new convention established in PR #2 and reinforced by John in PRs #16, #17, #18, #19, #54, #61, #62, #63: my/ is dead, replaced by workspace/ (user-edited content) and .local/ (kit bookkeeping).

The Python scripts (auth.py, setup.py, checkpoint.py, flightcheck/cli.py, every flightcheck check) were migrated correctly during the SFI cutover. The skill docs that the LLM reads at task time were not. This produces a class of silent failure: the LLM is told to write to my/connect/servicenow/config.json while auth.py reads from .local/connect/servicenow/config.json -- the same defect John flagged on PR #54, scaled to 30+ more files.

Mapping applied (mechanical, ordered to avoid prefix collisions)

Old path	New path	Reason
my/agents/	workspace/agents/	User-edited
my/onboarding/	workspace/onboarding/	User-visible state
my/flightcheck/	workspace/flightcheck/	User-visible reports
my/tests/	workspace/tests/	User-visible test sets
my/connect/	.local/connect/	Kit bookkeeping
my/config.json	.local/config.json	Kit bookkeeping
my/.token_cache.bin	.local/.token_cache.bin	Kit bookkeeping
my/.azure-login-attempts.json	.local/.azure-login-attempts.json	Kit bookkeeping

Files touched (39 docs + 1 runtime)

• .github/prompts/{connect,setup}.prompt.md
• scripts/flightcheck/AGENTS.md -- carries over from PR Add flightcheck developer guide (AGENTS.md) [reposted from #58] #61 follow-up
• scripts/flightcheck/pva_client.py:55 -- runtime fix; aligns with auth.py:127, graph_client.py:78, pp_admin_client.py:71
• src/reference/ess-docs/flightcheck/{permissions-required,remediation-guide}.md
• src/skills/cleanup/SKILL.md
• src/skills/connect/{SKILL.md,step1.md}
• src/skills/connect/azure/{app-registration,login}.md
• src/skills/connect/servicenow/ -- 11 files
• src/skills/connect/workday/{step1,step2,step3}.md
• src/skills/evaluations/{create,delete,update}/SKILL.md
• src/skills/flightcheck/SKILL.md
• src/skills/onboarding/{SKILL.md,step1b,step2,step3-flightcheck}.md
• src/skills/topics/{create,delete,update}/SKILL.md
• src/skills/troubleshoot/SKILL.md
• src/skills/workflows/{create,delete,update}/SKILL.md

Not changed (intentional)

• scripts/auth.py:44 -- historical comment referencing the migration itself; accurate as-is
• scripts/flightcheck/checks/local_files.py:342 -- same
• src/examples/ess-samples/ -- vendored upstream sample content

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature
• Breaking change
• Documentation update
• Refactor / cleanup

Testing

• ruff check scripts/ src/mcp/ -- passes locally
• python -m compileall -q scripts/ src/mcp/ -- passes locally
• Diff is one-for-one substitutions: 159 insertions, 159 deletions across 40 files; reviewer can verify by spot-checking that every - line and corresponding + line differ only in the path mapping above

Checklist

• My code follows the existing style
• I have added/updated tests where applicable (n/a -- no test suite for skill markdown)
• I have updated documentation as needed

[nehaoss]

Bulk path migration from \my/\ to .local/\ (and \workspace/\ for some paths). Clean mechanical change across 40 files.

Comments:

1. Scope: 159 additions / 159 deletions across 40 files — pure rename, no logic changes. Good that it's isolated from feature work.

2. Consistency check needed: With 40 files touched, verify no references to the old \my/\ path remain. Run \grep -r 'my/' --include='.md' --include='.py' --include='*.json'\ in the solutions folder to confirm completeness.

3. Breaking change for existing users: Users with existing \my/config.json, \my/connect/, \my/.token_cache.bin\ etc. will lose their state after pulling this change. Consider adding a migration note in the PR description (or a one-time migration script) so existing kit users know to move their local files.

4. Prompt file updates: The \connect.prompt.md\ and \setup.prompt.md\ changes point to the new paths — good that these are included.