Fix result handoff and deferred action continuations - #3073
Merged
George Ng (GeorgeNgMsft) merged 4 commits intoSep 25, 2026
Merged
Conversation
George Ng (GeorgeNgMsft)
added this pull request to stack #3074
September 25, 2026 01:40
jebrans
approved these changes
Sep 25, 2026
Separate optional entity names from concrete result values and deferred translation context. Preserve completed outputs without replaying producers, reject missing or invalid consumers, and add offline regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
George Ng (GeorgeNgMsft)
force-pushed
the
georgengmsft-result-entity-handoff-fixes
branch
from
September 25, 2026 19:21
964c682 to
73d9e68
Compare
George Ng (GeorgeNgMsft)
removed this pull request from stack #3074
September 25, 2026 19:26
George Ng (GeorgeNgMsft)
changed the base branch from
georgengmsft-ghcp-eval-implementation
to
main
September 25, 2026 19:26
Report unexecuted remaining steps without automatic continuation, reasoning fallback, or replay. Preserve standalone choices and structured choice handling. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Project result data without execution metadata or duplicate representations and enforce a 64 KiB serialized UTF-8 context limit before deferred translation. Preserve distinct data and fail explicitly instead of replaying producers or translating from truncated results. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Recheck translated continuations before enqueueing effects and preserve active schema/family restrictions. Stop explicitly without replay when scope is unavailable or actions are disabled. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This standalone product fix addresses intermediate-result handoff failures surfaced by the GHCP evaluation. Successful actions no longer fail simply because translation assigned a result label without an entity, deferred requests remain in the execution queue, and concrete result references are resolved before their consumers run. The PR targets
maindirectly, without eval-harness changes or a dependency on #3072.resultValuereferences, and deferred translation context. Missing consumed data still fails; display text and structured displayrawDataare not silently substituted as typed values.$resultsubstitution remains lossless and outside this limit.Evidence and scope
The recorded evaluation contains nine explicit missing-result-entity errors across
readFile,getList,clearList,prFiles, andprChecks, each after handler success. OneclearListmutation persisted before the failure. Full translated plans were not retained, so the traces do not establish which labels were unused versus consumed. This PR fixes the eager invariant and independently reproduced queue/resolver defects without inventing handler entities or claiming all nine workflows now complete. No live eval was rerun and no success-rate improvement is claimed.Automatic queue resumption after a legacy choice and large-output retrieval/chunking are intentionally not implemented.
Validation and review
mainwithout changing its contents; eval commits were removed. The original isolated head passed the full dispatcher suite (135 suites / 2,152 tests, 12 existing skips) and action-schema suite (4 suites / 332 tests, 62 existing skips).5d5e23fa6through bounded-fix head725a624a6. Two newly exposed deferred-path issues were independently validated: missing execution-eligibility checks and dropped caller schema restrictions. Both were then corrected in2029d4fc1; six regression failures were reproduced before the corrections. Review comments were not posted or resolved.origin/main.2029d4fc1029cf4e9e34872a076f5943c88f5983: build-ts run 36187276971 passed all six Windows/Linux/macOS × Node 22/24 jobs. All applicable PR checks also pass, including Linux/Windows Shell & CLI smoke tests, shell packaging on all three operating systems, .NET, CodeQL, formatting, repository policy, and documentation generation. The fork-only formatting check is skipped as expected.The original Linux/macOS CI failures were inherited eval portability issues, fixed separately in #3072 (
b47f8bacd), whose six-job OS/Node matrix is green. #3072 and #3077 remain in their own eval stack.