Update main for TS7 tagged releases - #64286
Jake Bailey (jakebailey) wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The release configuration script’s SemVer validation accepts invalid versions and rejects valid build metadata.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Restores and modernizes release-branch automation for upcoming releases.
Changes:
- Adds shared release-version configuration and branch synchronization.
- Updates branch creation/version workflows with validation.
- Improves cherry-pick baseline conflict handling.
File summaries
| File | Description |
|---|---|
tools/scripts/configure-release.mjs |
Synchronizes release version declarations. |
Herebyfile.mjs |
Disables nightly VSIX builds on release branches. |
.github/workflows/sync-branch.yaml |
Adds release-branch synchronization. |
.github/workflows/set-version.yaml |
Modernizes version updates. |
.github/workflows/new-release-branch.yaml |
Modernizes release-branch creation. |
.github/workflows/create-cherry-pick-pr.yml |
Improves cherry-pick validation and baselines. |
.github/disabled-workflows/sync-branch.yaml |
Removes the obsolete disabled workflow. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
Two workflows copy the release script without its required SemVer module, causing configuration to fail.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
.github/workflows/set-version.yaml:80
configure-release.mjsimports./semver.mjs, but this step copies only the entry point into$RUNNER_TEMP. Node resolves that import relative to the copied module, so the configure step fails withERR_MODULE_NOT_FOUNDbefore updating the branch. Copy the dependency alongside the script (or make the fetched script self-contained).
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Unsupported prereleases can be published as latest, and the package-test task fails standalone on clean checkouts.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Accepted prerelease versions can collide on the same GitHub tag after npm publication.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Balanced
In prep for 7.0.3.