Repository navigation
Python: Add installable Agent Framework builder skill - #9374
Eduard van Valkenburg (eavanvalkenburg) wants to merge 10 commits into
Conversation
GitHub Actions
Active
GitHub Actions
Active
agent-framework-automation
Bot
added
documentation
There was a problem hiding this comment.
🟡 Changes recommended
The guidance misstates Python support and makes inaccurate security claims about telemetry redaction and HTTP response limits.
3 open findings
What changed in this PR
Adds an installable Python Agent Framework builder skill and contributor guidance for maintaining it.
Changes:
- Adds guidance for agents, workflows, integrations, evaluation, observability, and hosting.
- Documents installation and repository discovery.
- Establishes ownership and maintenance expectations.
| File | Description |
|---|---|
skills/README.md |
Adds the consumer skill catalog. |
skills/agent-framework-builder-python/SKILL.md |
Defines the skill’s routing and core guidance. |
skills/agent-framework-builder-python/references/workflow-builder.md |
Documents workflows and orchestrations. |
skills/agent-framework-builder-python/references/observability.md |
Documents telemetry configuration. |
skills/agent-framework-builder-python/references/integrations.md |
Covers providers and integrations. |
skills/agent-framework-builder-python/references/hosting-and-deployment.md |
Covers hosting and deployment. |
skills/agent-framework-builder-python/references/harness-agent-builder.md |
Documents harness agents. |
skills/agent-framework-builder-python/references/evaluation.md |
Documents evaluation APIs. |
skills/agent-framework-builder-python/references/declarative.md |
Covers declarative construction. |
skills/agent-framework-builder-python/references/agent-builder.md |
Documents plain agents. |
README.md |
Advertises skill installation. |
python/AGENTS.md |
Adds consumer-skill maintenance guidance. |
.github/copilot-instructions.md |
Distinguishes public and contributor skills. |
.github/CODEOWNERS |
Assigns Python skill ownership. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: Findings reported
Scope: full PR (1 commit(s)): 1ca7119b63cf
Model: gpt-5.6-sol
Overview
The PR cleanly separates the installable consumer skill from contributor instructions and routes users through focused references, with several recommendations backed by current implementation guards and tests. The minimal harness example disables file memory, and the references include useful authorization, ownership, and sensitive-data warnings. Residual risk remains where later guidance permits the default unbounded file-memory store and where compatibility, response-size, and observability claims do not match current package metadata or runtime behavior.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
6 verified findings remained after source verification (1 high, 5 medium) across 5 files. Details are attached to the affected lines below.
Affected areas: skills/agent-framework-builder-python/SKILL.md, skills/agent-framework-builder-python/references/declarative.md, skills/agent-framework-builder-python/references/harness-agent-builder.md, skills/agent-framework-builder-python/references/integrations.md, and 1 more
1ca7119 to
831c0cc
Compare
GitHub Actions
Active
GitHub Actions
Active
GitHub Actions
Active
GitHub Actions
Active
GitHub Actions
Active
GitHub Actions
Active
GitHub Actions
Active
GitHub Actions
Active
b3b0dfa to
453ec41
Compare
GitHub Actions
Active
453ec41 to
0b1c643
Compare
GitHub Actions
Active
0b1c643 to
9ce4bf2
Compare
GitHub Actions
Active
GitHub Actions
Active
There was a problem hiding this comment.
MAF Automated Review — Iteration 2
Result: Findings reported
Scope: full PR (9 commit(s)): 5bd80b85c0cc, 8c60d016d266, 72de2327244d, 24dc34125dc8, c175182dfe58, f830554c9646, 24752f51dbcd, d537ec360560, 9ce4bf2c143b
Model: gpt-5.6-sol
Overview
The PR adds a well-structured installable Python consumer skill with progressive references, dedicated ownership, path-scoped validation, and explicit maintenance guidance. Its strongest guardrails cover hosted file-memory isolation and cleanup, bounded declarative HTTP responses, optional observability dependencies, and resource lifecycle ownership. Residual risk comes from an overbroad handoff compatibility claim, a resource validator that can approve links outside the installed skill, and an unpinned executable CLI fallback.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
3 verified findings remained after source verification (3 medium) across 2 files. Details are attached to the affected lines below.
Affected areas: .github/workflows/agent-skills.yml, skills/agent-framework-builder-python/SKILL.md
GitHub Actions
Active
|
|
||
| - [Agent Framework overview](https://learn.microsoft.com/agent-framework/overview/) | ||
| - [Your first agent](https://learn.microsoft.com/agent-framework/get-started/your-first-agent) | ||
| - [Python samples](https://github.com/microsoft/agent-framework/tree/main/python/samples) |
There was a problem hiding this comment.
Should the foundry-samples be mentioned as well, or are they not a main sample source?
Motivation & Context
Developers using coding agents currently have no installable, MAF-owned skill that explains the Python framework abstractions, helps select between agents, harness agents, workflows, and declarative definitions, and directs implementation toward current APIs and packages. Existing repository skills target contributors working on Agent Framework itself rather than customers building Agent Framework applications.
This adds a public Python consumer skill to the code repository while keeping it outside project-skill discovery locations. Repository coding agents therefore do not load it as contributor guidance, but contributor instructions require reviewing it when public Python APIs, packages, samples, integrations, or hosting behavior change.
This draft depends on #9363 for the documented Python 3.15 compatibility changes.
Description & Review Guide
agent-framework-builder-pythonunder the publicskills/catalog with a concise entry skill and focused references for agents, harness composition, workflows and orchestrations, declarative definitions, evaluation, observability, integrations, and hosting. Added install instructions, root README discovery, CODEOWNERS, contributor maintenance guidance, and a path-scoped workflow that validates the Agent Skills specification, relative resources, and GitHub publishing readiness.microsoft/agent-frameworkand receive current Python guidance, including the post-Python: Add Python 3.15 support and refresh dependencies #9363 Python compatibility model. Normal coding-agent work inside this repository continues to use the existing.github/skillsandAGENTS.mdinstructions without automatically loading the consumer skill. Changes underskills/now receive dedicated automated validation.Related Issue
Related to #7132
This PR delivers the Python consumer skill. The issue remains open for the .NET counterpart, and no competing open PR was found.
AI Assistance
AI assistance details: GitHub Copilot assisted with skill migration, API and documentation review, reference organization, validation, and the PR description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and the title prefix in sync automatically.