Skip to content

Python: fix Foundry Toolbox quickstart commands and setup steps - #9550

Open
Hui Miao (huimiu) wants to merge 9 commits into
microsoft:mainfrom
huimiu:hui/maf-toolbox-quickstart-fix
Open

Hui Miao (huimiu) wants to merge 9 commits into
microsoft:mainfrom
huimiu:hui/maf-toolbox-quickstart-fix

Conversation

@huimiu

@huimiu Hui Miao (huimiu) commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Motivation & Context

The toolbox README initializes the separate foundry-samples project from a deleted manifest, then refers to a toolbox.yaml that project no longer supplies. Update the affected azd steps to use its unified azure.yaml and preserve unrelated wording and headings.

Description & Review Guide

  • What are the major changes? Initialize from azure.yaml with -t, document azd >=1.34.2 and azure.ai.agents >=1.0.0-beta.19, run subsequent commands from the generated project directory, and list external inputs before initialization. Replace the missing toolbox.yaml/manual endpoint steps with dependency configuration and the generated endpoint mapping. Provision first, authorize the project's managed identity on the Language resource, and deploy all services before running locally. Remove the nonexistent model-selection prompt claim and clarify that the Foundry MCP caller needs delegated Entra user context. These corrections follow docs: clarify toolbox sample prerequisites and setup microsoft-foundry/foundry-samples#1082 and Fix init flags, paths, and add CLI alternatives microsoft-foundry/foundry-samples#1084. The -t minimum versions are documented in docs: update azd agent template syntax and minimum versions microsoft-foundry/foundry-samples#1078.
  • What is the impact of these changes? The azd walkthrough follows the deployment project's connection, toolbox, and agent dependencies. Authentication guidance distinguishes the caller's required user context from the hosted runtime's own managed-identity credentials. Original headings and unrelated manual setup, framework explanation, and VS Code instructions are unchanged. Runtime code and manifests are unchanged.
  • What do you want reviewers to focus on? Check the initialization directory, dependency ordering, versioned endpoint wiring, and caller identity requirements. git diff --check passed. Relative-link, original-heading, template/minimum-version contract, caller-context distinction, and prerequisite-order checks passed. The canonical manifest and the beta.19 extension manifest requiring azd >=1.34.2 were inspected. Builds and unit tests were not run locally for this documentation-only change. No Azure deployment or live invocation was performed.

Related Issue

N/A - trivial change: correct obsolete sample commands without changing runtime behavior. The open toolbox tool-search PRs (#9113 and #9008) address a different feature.

AI Assistance

  • No material AI assistance was used.
  • This is an AI-assisted contribution. I reviewed, understood, and verified all submitted content and accept responsibility for it.

AI assistance details: Copilot assisted with the README correction and PR description.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR links to an agreed issue with no competing open PR, or the Related Issue section documents a trivial-change or repository-automation exception.
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

Copilot AI lite review requested due to automatic review settings October 20, 2026 02:09
@agent-framework-automation agent-framework-automation Bot added documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs python Usage: [Issues, PRs], Target: Python labels Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Two moderate documentation issues remain unresolved.

No open issues 🎉

What changed in this PR

Documentation-only update separating local Agent Framework development from the canonical Foundry Toolbox deployment sample.

Changes:

  • Links deployment guidance to the canonical foundry-samples quickstart.
  • Adds local setup, environment variables, and execution instructions.
  • Corrects integration terminology to FoundryToolbox.
File Summary
python/​samples/​04-hosting/​foundry-hosted-agents/​responses/​foundry_toolbox/​README.md Revised deployment and local-development documentation. Two moderate findings remain (1 vote each): stale “manifest” wording and a Windows-only local-run path.

Review effort: Lite

@huimiu Hui Miao (huimiu) changed the title Python: point toolbox deployment docs to the canonical Foundry sample Python: fix Foundry Toolbox quickstart commands and setup steps Oct 20, 2026

This branch was successfully deployed

1 active deployment
github-app-auth — 0df94512 Deployed Oct 20, 2026 by huimiu via add_label #25797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants