Repository navigation
Python: fix Foundry Toolbox quickstart commands and setup steps - #9550
Open
Hui Miao (huimiu) wants to merge 9 commits into
Open
Hui Miao (huimiu) wants to merge 9 commits into
Hui Miao (huimiu) wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Two moderate documentation issues remain unresolved.
No open issues 🎉
What changed in this PR
Documentation-only update separating local Agent Framework development from the canonical Foundry Toolbox deployment sample.
Changes:
- Links deployment guidance to the canonical
foundry-samplesquickstart. - Adds local setup, environment variables, and execution instructions.
- Corrects integration terminology to
FoundryToolbox.
| File | Summary |
|---|---|
python/samples/04-hosting/foundry-hosted-agents/responses/foundry_toolbox/README.md |
Revised deployment and local-development documentation. Two moderate findings remain (1 vote each): stale “manifest” wording and a Windows-only local-run path. |
Review effort: Lite
Hui Miao (huimiu)
marked this pull request as ready for review
October 20, 2026 03:22
Hui Miao (huimiu)
requested review from
Tao Chen (TaoChenOSU) and
Giles Odigwe (giles17)
as code owners
October 20, 2026 03:22
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The toolbox README initializes the separate foundry-samples project from a deleted manifest, then refers to a toolbox.yaml that project no longer supplies. Update the affected azd steps to use its unified azure.yaml and preserve unrelated wording and headings.
Description & Review Guide
-t, document azd >=1.34.2 and azure.ai.agents >=1.0.0-beta.19, run subsequent commands from the generated project directory, and list external inputs before initialization. Replace the missing toolbox.yaml/manual endpoint steps with dependency configuration and the generated endpoint mapping. Provision first, authorize the project's managed identity on the Language resource, and deploy all services before running locally. Remove the nonexistent model-selection prompt claim and clarify that the Foundry MCP caller needs delegated Entra user context. These corrections follow docs: clarify toolbox sample prerequisites and setup microsoft-foundry/foundry-samples#1082 and Fix init flags, paths, and add CLI alternatives microsoft-foundry/foundry-samples#1084. The-tminimum versions are documented in docs: update azd agent template syntax and minimum versions microsoft-foundry/foundry-samples#1078.git diff --checkpassed. Relative-link, original-heading, template/minimum-version contract, caller-context distinction, and prerequisite-order checks passed. The canonical manifest and the beta.19 extension manifest requiring azd >=1.34.2 were inspected. Builds and unit tests were not run locally for this documentation-only change. No Azure deployment or live invocation was performed.Related Issue
N/A - trivial change: correct obsolete sample commands without changing runtime behavior. The open toolbox tool-search PRs (#9113 and #9008) address a different feature.
AI Assistance
AI assistance details: Copilot assisted with the README correction and PR description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.