Skip to content

Python: fix(memory): return no results for a non-positive transcript search limit #9907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lisry-1 wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

Python: fix(memory): return no results for a non-positive transcript search limit #9907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/packages/core/agent_framework/_harness/_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,6 +924,8 @@ def search_transcripts(
normalized_query = query.strip()
if not normalized_query:
raise ValueError("query must not be empty.")
if limit <= 0:
return []
query_casefold = normalized_query.casefold()
transcripts_directory = self.get_transcripts_directory(session, source_id=source_id)
if not transcripts_directory.exists():
Expand Down
15 changes: 15 additions & 0 deletions python/packages/core/tests/core/test_harness_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,21 @@ async def test_search_transcripts_returns_nothing_for_unknown_session(tmp_path)
)


async def test_search_transcripts_non_positive_limit_returns_nothing(tmp_path) -> None:
"""A non-positive limit must return no results, not a single row."""
session = AgentSession(session_id="session-1")
session.state["owner_id"] = "user-1"
store = MemoryFileStore(tmp_path, owner_state_key="owner_id")
await _write_transcript(store, session, "session-1", "Matching transcript.")

assert store.search_transcripts(
session, source_id=DEFAULT_MEMORY_SOURCE_ID, query="transcript", limit=0
) == []
assert store.search_transcripts(
session, source_id=DEFAULT_MEMORY_SOURCE_ID, query="transcript", limit=-1
) == []


def test_memory_file_store_rejects_owner_path_traversal(tmp_path) -> None:
"""Owner IDs with path traversal segments should not escape ``base_path``."""
session = AgentSession(session_id="session-1")
Expand Down
Loading