Skip to content

Python: fix(azure-cosmos): reject empty session_id instead of generating an orphan GUID #9908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lisry-1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Python: fix(azure-cosmos): reject empty session_id instead of generating an orphan GUID #9908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cedf2c
fix(azure-cosmos): raise ValueError for empty session_id instead of g…
lisry-1 Oct 31, 2026
d28c798
test(azure-cosmos): cover empty-string session id rejection
lisry-1 Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions python/packages/azure-cosmos/agent_framework_azure_cosmos/_history_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,6 @@ async def _ensure_container_proxy(self) -> None:

@staticmethod
def _session_partition_key(session_id: str | None) -> str:
if session_id:
return session_id

generated_session_id = str(uuid.uuid4())
logger.warning(
"Received empty session_id; generated temporary session id '%s' for Cosmos partition key.",
generated_session_id,
)
return generated_session_id
if not session_id:
raise ValueError("session_id must be a non-empty string.")
return session_id
24 changes: 7 additions & 17 deletions python/packages/azure-cosmos/tests/test_cosmos_history_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,26 +189,16 @@ async def test_empty_returns_empty(self, mock_container: MagicMock) -> None:

assert messages == []

async def test_none_session_id_generates_guid_partition_key(
self, mock_container: MagicMock, caplog: pytest.LogCaptureFixture
@pytest.mark.parametrize("session_id", [None, ""], ids=["none", "empty"])
async def test_missing_session_id_raises_value_error(
self, mock_container: MagicMock, session_id: str | None
) -> None:
mock_container.query_items.return_value = _to_async_iter([])

provider = CosmosHistoryProvider(source_id="mem", container_client=mock_container)
with caplog.at_level("WARNING"):
await provider.get_messages(None)

query_kwargs = mock_container.query_items.call_args.kwargs
session_key = query_kwargs["partition_key"]
assert isinstance(session_key, str)
assert session_key != ""
assert session_key != "default"
uuid.UUID(session_key)
assert query_kwargs["parameters"] == [
{"name": "@session_id", "value": session_key},
{"name": "@source_id", "value": "mem"},
]
assert "Received empty session_id" in caplog.text
with pytest.raises(ValueError, match="session_id"):
await provider.get_messages(session_id)

mock_container.query_items.assert_not_called()

async def test_skips_non_dict_message_payload(self, mock_container: MagicMock) -> None:
mock_container.query_items.return_value = _to_async_iter([{"message": "bad"}, {"message": None}])
Expand Down
Loading