Skip to content

auth: add optional account label - #607

Draft
TylerLeonhardt wants to merge 1 commit into
mainfrom
auth/optional-account-label
Draft

TylerLeonhardt wants to merge 1 commit into
mainfrom
auth/optional-account-label

Conversation

@TylerLeonhardt

Copy link
Copy Markdown
Member

Summary

Follow up on #583 with an optional AuthenticateParams.accountLabel, covering the display label currently carried in private metadata by microsoft/vscode#347244.

  • Define the label as display-only: it is not an account identifier or authorization input and need not be unique or stable.
  • Keep it optional independently of accountId, with no capability or protocol-version change.
  • Regenerate native client models and JSON schemas, update the authentication documentation and changelog fragment, and add schema validation plus a shared round-trip fixture.

Wire compatibility is preserved. Rust struct literals must add account_label: None when omitting the label; existing Kotlin data-class binaries must be rebuilt.

Validation

  • npm run generate
  • npm run test — 672 passed, including typecheck, lint, generation checks, schema tests, and reducer coverage.
  • Protocol and TypeScript client typechecks passed again before opening this draft.
  • Shared round-trip corpus passed for TypeScript, Rust, Go, Kotlin, and .NET (.NET: 115 tests).
  • Swift's generated AuthenticateParams passed the three shared authentication round-trip fixtures through a temporary SwiftPM executable. The full XCTest suite could not run because the local command-line toolchain lacks XCTest.
  • git diff --check

Extend authenticate with an optional display-only accountLabel alongside the accountId introduced in #583. Regenerate native models and schemas, document compatibility, and cover the field in schema validation and shared round-trip fixtures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant