Repository navigation
auth: add optional account label - #607
Draft
TylerLeonhardt wants to merge 1 commit into
Draft
TylerLeonhardt wants to merge 1 commit into
TylerLeonhardt wants to merge 1 commit into
Conversation
Extend authenticate with an optional display-only accountLabel alongside the accountId introduced in #583. Regenerate native models and schemas, document compatibility, and cover the field in schema validation and shared round-trip fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #583 with an optional
AuthenticateParams.accountLabel, covering the display label currently carried in private metadata by microsoft/vscode#347244.accountId, with no capability or protocol-version change.Wire compatibility is preserved. Rust struct literals must add
account_label: Nonewhen omitting the label; existing Kotlin data-class binaries must be rebuilt.Validation
npm run generatenpm run test— 672 passed, including typecheck, lint, generation checks, schema tests, and reducer coverage.AuthenticateParamspassed the three shared authentication round-trip fixtures through a temporary SwiftPM executable. The full XCTest suite could not run because the local command-line toolchain lacks XCTest.git diff --check