test(websocket): cover setExtraHTTPHeaders and locale on the handshake request - #42037
Open
dcrousso wants to merge 1 commit into
Open
test(websocket): cover setExtraHTTPHeaders and locale on the handshake request#42037dcrousso wants to merge 1 commit into
setExtraHTTPHeaders and locale on the handshake request#42037dcrousso wants to merge 1 commit into
Conversation
…shake request `Network.setExtraHTTPHeaders` and an emulated `locale` now reach the `WebSocket` handshake request, but nothing exercised either from the page or from inside a `Worker` Chromium: - <https://chromium-review.googlesource.com/c/chromium/src/+/7950740> (Network.setExtraHTTPHeaders should affect WebSocket handshake requests) - <https://chromium-review.googlesource.com/c/chromium/src/+/8000530> (Network.setExtraHTTPHeaders should affect WebSocket requests in a Worker) WebKit: - <WebKit/WebKit#67097> (Web Inspector: Network.setExtraHTTPHeaders does not affect WebSocket) Chrome Stable and Edge Stable are both still on 150, which predates that Chromium work, so widen the existing guard to `browserMajorVersion < 151` and reuse it on the new cases Firefox drops the browsing context association when it opens the handshake channel, so the `Worker` cases stay `it.fixme` there until the bundled Firefox picks up <https://phabricator.services.mozilla.com/D310690>
Contributor
Test results for "MCP"1 failed 7807 passed, 1266 skipped Merge workflow run. |
Contributor
🟢 CI is clear — the one failure is a pre-existing Firefox-on-Windows flakeHi, I'm the Playwright bot and I took a first look at the CI failures here. The single failure — DetailsOverall: 1 failed, 7807 passed, 1266 skipped. The one failure is a known pre-existing flake; nothing here looks caused by the PR. Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
Contributor
Test results for "tests 1"5 flaky50936 passed, 1190 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network.setExtraHTTPHeadersand an emulatedlocalenow reach theWebSockethandshake request, but nothing exercised either from the page or from inside aWorkerChromium:
WebKit:
Network.setExtraHTTPHeadersdoes not affectWebSocketWebKit/WebKit#67097 (Web Inspector: Network.setExtraHTTPHeaders does not affect WebSocket)Chrome Stable and Edge Stable are both still on 150, which predates that Chromium work, so widen the existing guard to
browserMajorVersion < 151and reuse it on the new casesFirefox drops the browsing context association when it opens the handshake channel, so the
Workercases stayit.fixmethere until the bundled Firefox picks up https://phabricator.services.mozilla.com/D310690fixes #13919
fixes #28948