Repository navigation
fix(cookies): follow RFC 6265 domain and path matching in cookies(urls) - #43148
Merged
Merged
Conversation
Pavel Feldman (pavelfeldman)
approved these changes
Oct 6, 2026
Contributor
Test results for "tests 1"1 failed 3 flaky52666 passed, 1270 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 The failure is a pre-existing flake — this PR is clearThe only red test is a test-runner interruption flake with exact failures on unrelated PRs. This PR only changes cookie domain and path matching, so it does not exercise the failing trace-retention path. DetailsPre-existing flake / infra
The three flaky entries in the report passed on retry and do not change the verdict. Triaged by the Playwright bot - agent run |
Contributor
Test results for "MCP"9035 passed, 1495 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
merged commit Oct 6, 2026
f553916
into
microsoft:main
44 of 45 checks passed
Pavel Feldman (pavelfeldman)
added a commit
to pavelfeldman/playwright-python
that referenced
this pull request
Oct 15, 2026
Roll the driver to 1.65.0-alpha-1792021904000 (microsoft/playwright@d96199f58) and Node.js to 24.22.0. Generate the API from microsoft/playwright main with microsoft/playwright#43407. The docs there have the Python type names and handler types, so most of python_rules.js is not needed. - Remove the extraClasses, skipArgs, argNames, typeOverrides, positional, structRenames and structNamesByPlace tables. - Struct names follow the docs: HttpHeader, WebStorageItem, ScreenSize, RecordVideoSize, Clip and Location. The fields are the same. - not_to_have_accessible_description(name) is now (description). - Locator.highlight() returns a Disposable, like in JS. - dispatch_event(event_init=) accepts any value, like in Java and C#. - Disposable has close() and no dispose(); use close() or a context manager. - Tests follow two driver changes: cookies(urls) matches domains as in RFC 6265 (microsoft/playwright#43148), and fill() no longer rejects malformed date and time values (microsoft/playwright#43400).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browserContext.cookies(urls)andapiRequestContext.cookies(urls)no longer return host-only cookies for subdomains, orPath=/apicookies for/apiv2.pathMatchesfollows RFC 6265 §5.1.4, soPath=/foo/does not match/foo.filterCookies); the second filtering pass infetch.tsis gone.Fixes #43078