Fixed mapped types not being considered as homomorphic with substitution constraints#4596
Open
Andarist wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeScript checker behavior in the Go port so that mapped types remain homomorphic even when their keyof T constraint flows through a substitution type (matching the regression described in microsoft/TypeScript#63132). It also adds a targeted compiler regression test and commits the corresponding reference baselines.
Changes:
- Unwrap substitution types when detecting a homomorphic mapped type variable, so
keyof T extends ... ? { [K in keyof T]: ... } : ...continues to be recognized as homomorphic. - Add a new compiler test case reproducing the scenario from the linked upstream issue.
- Add committed
.typesand.symbolsreference baselines for the new test.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/checker/checker.go |
Adjusts homomorphic mapped type detection to use the “actual” (unsubstituted) type variable. |
testdata/tests/cases/compiler/mappedTypeNotMistakenlyHomomorphic2.ts |
New regression test covering homomorphic behavior through conditional wrapping. |
testdata/baselines/reference/compiler/mappedTypeNotMistakenlyHomomorphic2.types |
Reference type baseline for the new test. |
testdata/baselines/reference/compiler/mappedTypeNotMistakenlyHomomorphic2.symbols |
Reference symbol baseline for the new test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes microsoft/TypeScript#63132