Add MPFD Support#10664
Conversation
|
No changes needing a change description found. |
1984387 to
f795535
Compare
b4ca108 to
edaf87f
Compare
19689f8 to
fd47b14
Compare
493c81f to
cbcc75b
Compare
cbcc75b to
98780a9
Compare
commit: |
98780a9 to
e74651b
Compare
JoshLove-msft
left a comment
There was a problem hiding this comment.
Reviewed the production source (emitter TS, Input layer, ClientModel/Core generators). Overall the MPFD design is sound and well-tested. Two inline notes below: one medium correctness concern about mutating a shared cached type in the emitter, and one minor dead-branch nit. Everything else (multipart serialization gating, optional/required handling, isMulti per-element emission, Input converters + Json-usage rule, SCME0004 Experimental gating, constructor augmentation, optional-body MediaType forwarding) looks correct.
--generated by Copilot
JoshLove-msft
left a comment
There was a problem hiding this comment.
Re-reviewed after the pr feedback commit (0dcdf53). Both of my earlier comments are resolved — thanks:
- The dead
stream.Position > int.MaxValuebranch inMultipartFormDataHelperDefinition.csis gone; the helpers now returnBinaryData.FromBytes(stream.GetWrittenMemory(), mediaType)directly. ✅ - The shared-
bytescache mutation is fixed by cloning, and the newdoes not mutate cached bytes types when marking a multipart bytes file parttest locks in the invariant (asserting no cachedbytescarriesisFileType). ✅ Nice regression test.
One residual, inline: the same mutation-of-shared-cache pattern still applies to the model and array-of-model branches, which were not cloned.
--generated by Copilot
This PR adds support for generating convenience client methods for multipart/form-data request.
contributes to : #9548