-
Notifications
You must be signed in to change notification settings - Fork 374
Sample Generation - ExampleValueExpressionBuilder and OperationSample parity with autorest generator #10739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaiLinhP
wants to merge
12
commits into
microsoft:main
Choose a base branch
from
MaiLinhP:sample
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sample Generation - ExampleValueExpressionBuilder and OperationSample parity with autorest generator #10739
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ca8a3fd
OperationSample
MaiLinhP 37a75fe
Change TokenCredential to add DefaultAzureCredential for parity with …
MaiLinhP 18188f3
fix spelling
MaiLinhP 002eabc
Change to ScmOutputLibrary and ScmMethodProviderCollection to allow f…
MaiLinhP 439f45b
minor form change
MaiLinhP f1083c8
Change credential type reference
MaiLinhP d720759
Move Sample building into ClientSampleProvider
MaiLinhP 8076e7b
Run Generate.ps1
MaiLinhP 0b76293
Add custom example samples to compare with auto generated mock versions
MaiLinhP d8f9f89
regen change
MaiLinhP bce587f
fix conflict
MaiLinhP 7f31520
Fix tests to match expected behavior
MaiLinhP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
577 changes: 577 additions & 0 deletions
577
...or/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/Samples/ClientSampleProvider.cs
Large diffs are not rendered by default.
Oops, something went wrong.
55 changes: 55 additions & 0 deletions
55
...r/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/Samples/ExampleParameterValue.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using Microsoft.TypeSpec.Generator.Expressions; | ||
| using Microsoft.TypeSpec.Generator.Input; | ||
| using Microsoft.TypeSpec.Generator.Primitives; | ||
|
|
||
| namespace Microsoft.TypeSpec.Generator.ClientModel.Providers.Samples | ||
| { | ||
| /// <summary> | ||
| /// Represents a parameter value in a sample. Supports two modes: | ||
| /// - <see cref="Value"/>: raw example data that will be converted to a C# expression later | ||
| /// - <see cref="Expression"/>: a pre-built C# expression (used for known parameters like credentials, endpoints) | ||
| /// </summary> | ||
| public class ExampleParameterValue | ||
| { | ||
| public ExampleParameterValue(string name, CSharpType type, InputExampleValue value) | ||
| { | ||
| Name = name; | ||
| Type = type; | ||
| Value = value; | ||
| } | ||
|
|
||
| public ExampleParameterValue(string name, CSharpType type, ValueExpression expression) | ||
| { | ||
| Name = name; | ||
| Type = type; | ||
| Expression = expression; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// The parameter name. | ||
| /// </summary> | ||
| public string Name { get; } | ||
|
|
||
| /// <summary> | ||
| /// The C# type of the parameter. | ||
| /// </summary> | ||
| public CSharpType Type { get; } | ||
|
|
||
| /// <summary> | ||
| /// Raw example data from the spec or mock builder. Will be converted to a | ||
| /// <see cref="ValueExpression"/> via <see cref="ExampleValueExpressionBuilder"/>. | ||
| /// Mutually exclusive with <see cref="Expression"/>. | ||
| /// </summary> | ||
| public InputExampleValue? Value { get; } | ||
|
|
||
| /// <summary> | ||
| /// A pre-built C# expression. Used for known parameters (credentials, endpoints) | ||
| /// where the expression is fixed regardless of example data. | ||
| /// Mutually exclusive with <see cref="Value"/>. | ||
| /// </summary> | ||
| public ValueExpression? Expression { get; } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
using System.ClientModel;looks unused — nothing in the file references a type from that namespace root (ApiKeyCredential/ClientResult/BinaryContentare not used here). Appears to be a leftover from an earlier iteration; please remove it to avoid an unused-using warning.--generated by Copilot