Fix function call argument count errors reporting on declaration instead of call site#10859
Draft
Copilot wants to merge 2 commits into
Draft
Fix function call argument count errors reporting on declaration instead of call site#10859Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
… function declaration Fixes the diagnostic target for `invalid-argument-count` errors in function calls to point at the CallExpressionNode (the call site) instead of the function declaration node. This ensures errors are shown where the function is called, not where it is defined. Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix functions reporting errors on function declaration
Fix function call argument count errors reporting on declaration instead of call site
Jun 2, 2026
microsoft-github-policy-service
Bot
added
the
compiler:core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invalid-argument-countdiagnostics for function calls were targeting theextern fndeclaration node instead of the call expression, causing errors to appear on the wrong line.Changes
packages/compiler/src/core/checker.ts—checkFunctionCallArgumentsnow takes theCallExpressionNodeand uses it as the diagnostic target instead oftarget.node!packages/compiler/test/checker/functions.test.ts— Added test asserting the diagnostic targetsSyntaxKind.CallExpression