Skip to content

Productize PEP 723 inline script preview - #1938

Merged
Stella Huang (StellaHuang95) merged 1 commit into
mainfrom
stellahuang95-pep723-analysis
Oct 20, 2026
Merged

Stella Huang (StellaHuang95) merged 1 commit into
mainfrom
stellahuang95-pep723-analysis

Conversation

@StellaHuang95

Copy link
Copy Markdown
Contributor

Summary

  • add the public python-envs.inlineScripts.enabled preview setting with a default of false, requiresReload, and onExP rollout support
  • use one activation-latched decision across inline-script commands, diagnostics, manager registration, CodeLens, and quick fixes
  • document the preview and make automated test hosts explicitly default the feature off
  • add manifest and behavior coverage for the rollout contract

Validation

  • npm run lint
  • npm run compile-tests
  • npm run compile
  • npm run unittest — 3,295 passing, 9 pending
  • smoke tests — 31 passing, 1 pending
  • E2E tests — 4 passing
  • manual VS Code verification of settings precedence, command visibility, CodeLens/interpreter routing, and both true→false and false→true reload latching

The full integration run had 60 passing and 8 pending tests plus one pre-existing timeout in Created environment appears in discovery. The committed fixture selects the interactive system installer; the targeted test passes with a venv-configured fixture.

@bschnurr

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

Add a default-off experimental setting and use one activation-latched decision across commands, diagnostics, managers, CodeLens, and quick fixes. Update documentation and test coverage for gradual rollout.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 11d44bb8-39ba-4f1f-9a2c-379198878a3a
@bschnurr

Copy link
Copy Markdown
Member

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "79b48f88ce94bad21411fd93ba5645f72317e5f1446b0616ff05459bed198d95": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Oct 20, 2026

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@StellaHuang95
Stella Huang (StellaHuang95) merged commit 747481c into main Oct 20, 2026
128 of 129 checks passed
@StellaHuang95
Stella Huang (StellaHuang95) deleted the stellahuang95-pep723-analysis branch October 20, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality review-auto:approved Automated review: no blocking findings (approval posted). skip package*.json

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants