Update protocol version and refine working directory handling in chat and session states - #327573
Merged
Conversation
… and session states
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Agent Host Protocol working-directory semantics by replacing per-chat primaries with an immutable first session directory.
Changes:
- Removes
primaryWorkingDirectoryfrom chat/session APIs and state projections. - Replaces
requiresPrimarywithimmutablePrimary. - Updates Claude metadata documentation.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/agentHost/node/claude/CONTEXT.md |
Updates session metadata documentation. |
src/vs/platform/agentHost/common/state/sessionState.ts |
Removes per-chat primary projections. |
src/vs/platform/agentHost/common/state/protocol/channels-session/state.ts |
Documents session-level immutable primary semantics. |
src/vs/platform/agentHost/common/state/protocol/channels-session/commands.ts |
Removes default-chat primary creation input. |
src/vs/platform/agentHost/common/state/protocol/channels-session/actions.ts |
Documents immutable-primary removal constraints. |
src/vs/platform/agentHost/common/state/protocol/channels-root/state.ts |
Introduces immutablePrimary capability. |
src/vs/platform/agentHost/common/state/protocol/channels-chat/state.ts |
Removes primary directory from chat state. |
src/vs/platform/agentHost/common/state/protocol/channels-chat/commands.ts |
Removes primary directory from chat creation. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Medium
- Updated interfaces and implementations across various modules to replace single working directory references with arrays of working directories. - Modified session creation and metadata handling to accommodate multiple working directories. - Adjusted tests to reflect changes in session structure and ensure compatibility with the new working directory model. - Enhanced workspace building functions to properly utilize multiple directories for session management.
- Updated AgentService to truncate working directories for providers that do not support multipleWorkingDirectories. - Modified CopilotAgent to handle multiple working directories and persist them correctly. - Adjusted session launcher and session handler to support additional working directories. - Added tests to verify working directory truncation and persistence behavior. - Implemented computeWorkingDirectories function to derive the ordered set of working directories based on provider capabilities. - Updated related tests to ensure correct behavior for multi-root and single-root workspaces.
DonJayamanne
marked this pull request as ready for review
July 28, 2026 01:57
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
DonJayamanne
enabled auto-merge (squash)
July 28, 2026 02:12
roblourens
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of #327569