feat: schema store support - #327628
Open
baywet wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
CC @aeschli |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds SchemaStore catalog support to JSON language features.
Changes:
- Registers the public SchemaStore catalog.
- Loads remote registries through the schema request service.
- Refreshes associations when trust settings change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
extensions/json-language-features/package.json |
Registers the SchemaStore catalog. |
extensions/json-language-features/client/src/jsonClient.ts |
Supports trusted remote registry loading and refreshes. |
Comment on lines
+574
to
+577
| getSchemaAssociations(true, true).then(associations => { | ||
| schemaAssociationRefreshIncludesRemoteRegistries = true; | ||
| client.sendNotification(SchemaAssociationNotification.type, associations); | ||
| }); |
| : await getRegistryContent(registryUri.toString(true)); | ||
| const registry = <{ schemas?: { url?: string; fileMatch?: string[] }[] }>JSON.parse(rawStr); | ||
| if (Array.isArray(registry.schemas)) { | ||
| const result: ISchemaAssociation[] = []; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #325970
Supersedes #327297.