Fixes reveal comments in md editor bug - #327632
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds comment-reveal propagation from Agent Feedback through the extension host into the Markdown custom editor.
Changes:
- Introduces reveal events across feedback, bridge, proposed API, and IPC layers.
- Reveals and expands requested Markdown comments, including before webview readiness.
- Adds service-level coverage and updates mocks/lint configuration.
Show a summary per file
| File | Description |
|---|---|
src/vscode-dts/vscode.proposed.agentEditorComments.d.ts |
Exposes the reveal event. |
src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts |
Updates the feedback-service fixture. |
src/vs/workbench/services/agentEditorComments/common/agentEditorComments.ts |
Bridges reveal events. |
src/vs/workbench/api/common/extHostAgentEditorComments.ts |
Exposes reveals to extensions. |
src/vs/workbench/api/common/extHost.protocol.ts |
Adds the reveal RPC. |
src/vs/workbench/api/browser/mainThreadAgentEditorComments.ts |
Routes resource-specific reveals. |
src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackService.test.ts |
Tests reveal event payloads. |
src/vs/sessions/contrib/agentFeedback/browser/nullAgentFeedbackService.contribution.ts |
Implements the event in the null service. |
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackService.ts |
Emits reveal requests. |
src/vs/sessions/contrib/agentFeedback/browser/agentEditorCommentsProvider.ts |
Adapts feedback reveal events. |
extensions/markdown-language-features/src/preview/markdownEditorProvider.ts |
Forwards and buffers webview reveals. |
extensions/markdown-language-features/markdown-editor-src/editor.ts |
Reveals comments in the Markdown view. |
eslint.config.js |
Allows reveal in event names. |
Review details
- Files reviewed: 12/13 changed files
- Comments generated: 0
- Review effort level: Medium
hediet
marked this pull request as draft
July 27, 2026 14:15
auto-merge was automatically disabled
July 27, 2026 14:15
Pull request was converted to draft
hediet
force-pushed
the
hediet/b/shocked-centipede
branch
from
July 27, 2026 18:34
fe112bf to
1a2d853
Compare
hediet
marked this pull request as ready for review
July 27, 2026 18:34
hediet
enabled auto-merge (rebase)
July 27, 2026 18:34
roblourens
previously approved these changes
Jul 27, 2026
hediet
force-pushed
the
hediet/b/shocked-centipede
branch
from
July 28, 2026 12:29
fd54090 to
fb722cb
Compare
benibenj
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.