Fix high contrast submenu focus outlines - #327677
Open
hawkticehurst with Copilot wants to merge 2 commits into
Open
Fix high contrast submenu focus outlines#327677hawkticehurst with Copilot wants to merge 2 commits into
hawkticehurst with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: hawkticehurst <39639992+hawkticehurst@users.noreply.github.com>
Co-authored-by: hawkticehurst <39639992+hawkticehurst@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
hawkticehurst
July 27, 2026 18:21
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes high-contrast submenu focus outlines by limiting the selection border to the directly focused menu item.
Changes:
- Uses a direct-child selector for focused menu items.
- Adds regression coverage for nested submenus.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/base/browser/ui/menu/menu.ts |
Corrects high-contrast focus selector scoping. |
src/vs/base/test/browser/ui/menu/menu.test.ts |
Verifies nested items remain unoutlined. |
hawkticehurst
marked this pull request as ready for review
July 27, 2026 20:25
roblourens
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #327543
Summary
High contrast focus styling used a descendant selector, causing every item in an open submenu to receive an outline when its parent was focused.
Changes
Scope the outline to the focused action’s direct menu item:
Add regression coverage for nested submenu items.