Fix issues related with sandbox repair in dev containers. - #327680
Merged
Conversation
Signed-off-by: Dileep Yavanmandha <dileepy@microsoft.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @anthonykim1Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enables terminal sandboxing in containers while improving bubblewrap restriction handling and remediation.
Changes:
- Detects AppArmor restrictions and enables nested sandbox compatibility.
- Adds bubblewrap failure guidance and automated remediation.
- Expands sandbox and terminal tool tests.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/sandbox/common/sandboxHelperService.ts |
Adds AppArmor restriction status. |
src/vs/platform/sandbox/common/terminalSandboxEngine.ts |
Enables weaker nested sandbox mode. |
src/vs/platform/sandbox/node/sandboxHelper.ts |
Reads the AppArmor restriction flag. |
src/vs/platform/sandbox/test/common/terminalSandboxEngine.test.ts |
Tests nested sandbox behavior. |
src/vs/platform/sandbox/test/node/sandboxHelper.test.ts |
Tests AppArmor detection. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts |
Handles remediation and host restriction errors. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts |
Updates prerequisite test data. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts |
Tests remediation and guidance flows. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 4
- Review effort level: Medium
dileepyavan
marked this pull request as draft
July 27, 2026 18:43
dileepyavan
marked this pull request as ready for review
July 27, 2026 18:47
dileepyavan
enabled auto-merge (squash)
July 27, 2026 18:47
dileepyavan
changed the title
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
vijayupadya
approved these changes
Jul 27, 2026
dmitrivMS
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Fixes #316626