agentHost: correlate model message telemetry by client request - #327681
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Correlates model-message telemetry using the SDK’s client request ID.
Changes:
- Replaces service request IDs with client request IDs.
- Updates telemetry documentation and unit expectations.
Show a summary per file
| File | Description |
|---|---|
copilotAgentSession.ts |
Forwards clientRequestId to model telemetry. |
agentHostTelemetryReporter.ts |
Renames and documents the correlation parameter. |
agentHostTelemetryReporter.test.ts |
Updates expected request ID values. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Medium
zhichli
force-pushed
the
fix/agent-host-message-text-client-request-id
branch
from
July 27, 2026 18:46
8fc7d29 to
f65509b
Compare
zhichli
enabled auto-merge
July 27, 2026 18:48
roblourens
previously approved these changes
Jul 27, 2026
zhichli
force-pushed
the
fix/agent-host-message-text-client-request-id
branch
from
July 27, 2026 20:07
f65509b to
947f30a
Compare
dmitrivMS
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the SDK
clientRequestIdfor model-sourceconversation.messageText.headerRequestId, matching the legacy extension's client-mintedx-request-id. User-source rows remain turn-correlated byconversationId+turnIndex; consumers support that shape.Related to microsoft/vscode-internalbacklog#8247.
Testing
npm run gulp compilenode test/unit/node/index.js --run src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts(244 passing)