fix: show Modern UI hover on panel and secondary side bar tabs - #327683
Open
cipheraxat wants to merge 3 commits into
Open
fix: show Modern UI hover on panel and secondary side bar tabs#327683cipheraxat wants to merge 3 commits into
cipheraxat wants to merge 3 commits into
Conversation
Active pills already paint on .action-item while hover still targeted a hidden or .icon-only indicator path. Paint list-hoverBackground on the action item instead. Fixes microsoft#327676.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.action-item, but hover still targeted.active-item-indicator(hidden for icon tabs; side-bar hover also requires.icon, so panel text tabs never matched).var(--vscode-list-hoverBackground)on.action-item:not(.checked):hoverfor panel.titleand auxiliary bar.title/.header-or-footer, with the same drag-over guards as the side bar.color-mixpill (theming that separately is Active panel tabs are barely visible in Modern UI #327267).Test plan
workbench.experimental.modernUIand setworkbench.activityBar.locationtotop.style-overrideabsent; these hover rules do not apply