Skip to content

Revert "rotating empty state messaging" - #327694

Merged
justschen merged 2 commits into
mainfrom
revert-327542-justin/grapploct
Jul 27, 2026
Merged

Revert "rotating empty state messaging"#327694
justschen merged 2 commits into
mainfrom
revert-327542-justin/grapploct

Conversation

@justschen

Copy link
Copy Markdown
Collaborator

Reverts #327542

Copilot AI review requested due to automatic review settings July 27, 2026 19:55
@justschen
justschen enabled auto-merge (squash) July 27, 2026 19:56
@justschen justschen added the release-cherry-pick Automated cherry-pick between release and main branches label Jul 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the rotating chat placeholder feature, restoring static placeholder behavior.

Changes:

  • Removes placeholder rotation and shimmer transitions.
  • Restores one-time randomized placeholders for new sessions.
  • Updates Sessions documentation accordingly.
Show a summary per file
File Description
chatInputPlaceholderRotation.ts Removes rotation utilities and shared messages.
chatWidget.ts Restores static agent placeholders.
SESSIONS.md Removes rotation documentation.
newChatInput.ts Restores per-widget random placeholder selection.
placeholderTextContribution.ts Removes transition support.
placeholderText.css Removes shimmer animation styles.

Review details

  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Medium

pwang347
pwang347 previously approved these changes Jul 27, 2026
eleanorjboyd
eleanorjboyd previously approved these changes Jul 27, 2026
@justschen

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

…grapploct

# Conflicts:
#	src/vs/workbench/contrib/chat/browser/widget/input/chatInputPlaceholderRotation.ts

Co-authored-by: justschen <54879025+justschen@users.noreply.github.com>
Copilot AI dismissed stale reviews from eleanorjboyd and pwang347 via 28909ff July 27, 2026 20:20

Copilot AI commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 28909ff.

The only conflict was chatInputPlaceholderRotation.ts (deleted by this revert, modified on main by #327684 to skip rotation while dictating). Since the whole rotation feature is being reverted, I kept the deletion. activeDictationEditor() is still used by editorDictation.ts, so nothing on the dictation side breaks, and no references to the removed module remain. npm run typecheck-client passes.

@justschen justschen added the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label Jul 27, 2026
@vs-code-engineering

Copy link
Copy Markdown
Contributor

This PR will be automatically cherry-picked to release/1.131 when merged.

@justschen
justschen merged commit e444a86 into main Jul 27, 2026
29 checks passed
@justschen
justschen deleted the revert-327542-justin/grapploct branch July 27, 2026 20:49
@vs-code-engineering vs-code-engineering Bot removed the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label Jul 27, 2026
@vs-code-engineering vs-code-engineering Bot added this to the 1.132.0 milestone Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants