Repository navigation
feat: add support for duplicate tab functionality - #340912
Parth Raiyani (rparth07) wants to merge 2 commits into
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Kyle Cutler (@kycutler)Matched files:
Joaquín Ruales (@jruales)Matched files:
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
🟡 Changes recommended
Mnemonic handling affects unrelated menu actions, and duplicate-tab ignores multi-selected tabs.
2 open findings
What changed in this PR
Adds Integrated Browser tab duplication while preserving the source URL and tab independence.
Changes:
- Adds the Duplicate Tab command and clicked-tab targeting.
- Adds context-menu mnemonic support.
- Adds duplicate-tab and menu-label tests.
| File | Description |
|---|---|
src/vs/workbench/services/contextmenu/test/electron-browser/contextmenuService.test.ts |
Tests native mnemonic labels. |
src/vs/workbench/services/contextmenu/electron-browser/contextmenuService.ts |
Renders native menu mnemonics. |
src/vs/workbench/contrib/browserView/test/electron-browser/features/browserTabManagementFeatures.test.ts |
Tests duplication and visibility. |
src/vs/workbench/contrib/browserView/electron-browser/features/browserTabManagementFeatures.ts |
Implements Duplicate Tab. |
src/vs/workbench/common/contextkeys.ts |
Defines clicked-tab editor context. |
src/vs/workbench/browser/parts/editor/editorTabsControl.ts |
Populates the new context key. |
src/vs/platform/contextview/browser/contextMenuService.ts |
Requests mnemonic labels. |
src/vs/platform/contextview/browser/contextMenuHandler.ts |
Enables custom-menu mnemonics. |
src/vs/platform/browserView/common/browserView.ts |
Adds the command identifier. |
src/vs/platform/actions/test/common/menuService.test.ts |
Tests mnemonic action labels. |
src/vs/platform/actions/common/actions.ts |
Adds mnemonic-aware label rendering. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fe19895 to
c9069b3
Compare
c9069b3 to
7c28edc
Compare
2868b42 to
6d87424
Compare
|
Joaquín Ruales (@jruales) or Kyle Cutler (@kycutler), could you please review :) |
6f6193b to
a4adc1e
Compare
…tles in context menus and actions, including duplicate tab functionality Signed-off-by: Parth Raiyani <pmr642001@gmail.com>
a4adc1e to
83c31cb
Compare
|
Kyle Cutler (@kycutler), could you help confirm whether this Integrated Browser change is suitable for review, or suggest the right reviewer? Joaquín Ruales (@jruales) is currently assigned. |

This resolves issue #340911
How to test
.\scripts\code.bat.https://code.visualstudio.com.