Repository navigation
sessions: honor Agents window extension support overrides - #344242
Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit intoOct 26, 2026
Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit into
Benjamin Christopher Simmonds (benibenj) merged 1 commit into
Conversation
Honor explicit extensions.supportAgentsWindow overrides before the product allowlist, and register the setting in both window types. Fixes #341011 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
October 26, 2026 10:17
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
October 26, 2026 10:18
Federico Brancasi (federicobrancasi)
approved these changes
Oct 26, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes address both reported problems, preserve existing enablement constraints, and include targeted regression coverage.
No open issues 🎉
What changed in this PR
Fixes #341011 by honoring explicit extension-support overrides ahead of product defaults and making the setting available in both editor and Agents windows.
Changes:
- Gives
extensions.supportAgentsWindowoverrides precedence over the product allowlist. - Moves setting registration into the shared manifest-support module and clarifies opt-in, opt-out, and reload behavior.
- Adds regression coverage for overrides, allowlist defaults, global disables, and unchanged editor-window behavior.
No blocking issues were identified. The live UI scenario remains untested; the PR reports successful targeted tests and static checks.
| File | Description |
|---|---|
| src/vs/workbench/services/extensions/test/common/extensionManifestPropertiesService.test.ts | Tests shared registration and override precedence. |
| src/vs/workbench/services/extensions/common/extensionManifestPropertiesService.ts | Prioritizes overrides and registers the setting centrally. |
| src/vs/workbench/services/extensionManagement/test/browser/extensionEnablementService.test.ts | Tests opt-out behavior across window and management modes. |
| src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts | Removes the editor-only setting registration. |
Review effort: Balanced
Benjamin Christopher Simmonds (benibenj)
merged commit Oct 26, 2026
2a7037f
into
main
47 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
agents/create-a-fix-to-support-this-https-github
branch
October 26, 2026 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341011
Changes
extensions.supportAgentsWindowoverrides before the product allowlist, including"vue.volar": false.Validation
npm run build-fast -- --client-only? passed..\scripts\test.bat --reporter dot --run src\vs\workbench\services\extensions\test\common\extensionManifestPropertiesService.test.ts --run src\vs\workbench\services\extensionManagement\test\browser\extensionEnablementService.test.ts? passed, 185 tests.npm run typecheck-client? passed.npm run eslint -- src\vs\workbench\services\extensions\common\extensionManifestPropertiesService.ts src\vs\workbench\contrib\extensions\browser\extensions.contribution.ts src\vs\workbench\services\extensions\test\common\extensionManifestPropertiesService.test.ts src\vs\workbench\services\extensionManagement\test\browser\extensionEnablementService.test.ts? passed.npm run valid-layers-check? passed.git diff --check? passed.The standard dependency restore hit missing ClangCL build tools in a build-only native addon. Root dependencies and build tools restored without native scripts supported the successful checks above. No dependency manifest or lockfile changes are included.
Manual testing
Set
"extensions.supportAgentsWindow": { "vue.volar": false }with Vue installed and enabled, reload the Agents window, and verify that Vue stays disabled there but remains enabled in editor windows. Remove the override and reload to restore the product default. This live UI scenario was not run.