Skip to content

[cherry-pick] sessions: Clarify the Environment picker management label - #344352

Merged
Raymond Zhao (rzhao271) merged 1 commit into
mainfrom
cherry-pick/344326
Oct 26, 2026
Merged

Raymond Zhao (rzhao271) merged 1 commit into
mainfrom
cherry-pick/344326

Conversation

@vs-code-engineering

Copy link
Copy Markdown
Contributor

Cherry-pick of #344326 from release/1.144.

Summary

  • Rename Manage... in the Environment picker to Manage Remote Environments....
  • Align the setting description and chat/Remotes accessibility help with the new label.
  • Preserve the command, visibility gates, selected environment, and per-host Manage submenus.

Rebased onto origin/release/1.144 at 62620115296 to avoid the unrelated chat-move test regression introduced on main by #344057 (13832cc4487). The diff remains the same six-file label-only change. Follow-up to the release backports #344266 and #344313; related to #344263.

Validation

  • npm run build-fast -- --client-only - passed after rebasing onto release/1.144.
  • Focused picker and accessibility tests on release/1.144 - 79 passing:
.\scripts\test.bat --run src\vs\sessions\contrib\chat\test\browser\sessionEnvironmentPicker.test.ts --run src\vs\sessions\contrib\chat\test\browser\sessionsChatAccessibilityHelp.test.ts --reporter dot
  • Release-diff ESLint and hygiene - 6 files passed; whitespace check passed:
$files = @(git diff --name-only origin/release/1.144...HEAD -- '*.ts')
npm run eslint -- $files
node build\hygiene.ts $files
git diff --check origin/release/1.144...HEAD

This is a string-only change; full type-check and smoke/integration suites were not run.

Manual check

Open the Environment picker, select Manage Remote Environments..., and verify Remotes management opens without changing the selected environment.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 16:47
@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Oct 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The six-file change consistently updates localized wording and matching test expectations without altering runtime behavior, and no actionable issues remain.

No open issues 🎉

What changed in this PR

This cherry-pick clarifies the Agents window’s Environment picker management action, following the earlier remote-management backports without changing behavior.

Changes:

  • Rename Manage... to Manage Remote Environments....
  • Align the setting description and chat/Remotes accessibility help.
  • Update existing test expectations while preserving commands, visibility gates, selection, and per-host submenus.
File Description
src/​vs/​sessions/​contrib/​providers/​remoteAgentHost/​electron-browser/​remotes.contribution.ts Aligns Remotes accessibility help with the new label.
src/​vs/​sessions/​contrib/​chat/​test/​browser/​sessionsChatAccessibilityHelp.test.ts Updates the accessibility-help assertion.
src/​vs/​sessions/​contrib/​chat/​test/​browser/​sessionEnvironmentPicker.test.ts Updates picker label and visibility assertions.
src/​vs/​sessions/​contrib/​chat/​browser/​sessionsChatAccessibilityHelp.ts Updates chat accessibility guidance.
src/​vs/​sessions/​contrib/​chat/​browser/​sessionEnvironmentPicker.ts Renames the localized management action.
src/​vs/​sessions/​contrib/​chat/​browser/​chat.contribution.ts Aligns the setting description.

Review effort: Balanced

@rzhao271
Raymond Zhao (rzhao271) merged commit eb547db into main Oct 26, 2026
50 checks passed
@rzhao271
Raymond Zhao (rzhao271) deleted the cherry-pick/344326 branch October 26, 2026 17:48
@vs-code-engineering vs-code-engineering Bot added this to the 1.144.0 milestone Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants