Skip to content

ci: Run Moby extension integration tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvoland merged 2 commits into from
Oct 1, 2026
Merged

ci: Run Moby extension integration tests #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91e098b
ci: Run Moby extension tests
vvoland Sep 23, 2026
ca92a86
ci: Regenerate Moby files before integration tests and report the diff
vvoland Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,86 @@ jobs:
run: |
go test -race ./...

moby-integration:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
-
name: Checkout extensions
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
path: extensions
ref: ${{ github.event.pull_request.head.sha || github.sha }}
-
name: Checkout Moby
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: moby/moby
ref: master
path: moby
-
name: Set up Go
uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version-file: moby/go.mod
cache-dependency-path: |
moby/go.sum
extensions/go.sum
-
name: Prepare Moby dependencies
working-directory: moby
run: |
go mod edit -replace=github.com/moby/extensions="${GITHUB_WORKSPACE}/extensions"
go mod tidy
go mod vendor
Comment on lines +95 to +97

@thaJeztah thaJeztah Sep 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should look if go.work is suitable for this;

go work init .
go work edit -replace=github.com/moby/extensions="${GITHUB_WORKSPACE}/extensions"
go work vendor

@vvoland vvoland Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's any difference in this case? It's only a temporary checkout to run the tests from

@thaJeztah thaJeztah Oct 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah; I was trying to see if we could make it more align with the intended use of Go.

I was hoping go.work could "augment" the replaced module;

  • use github.com/moby/moby and vendor/
  • but use ${GITHUB_WORKSPACE}/extensions for the extensions module

But unfortunately that doesn't work when using vendor/ - in that case, it only looks at the vendor/ directory so it either must re-vendor, or we need to disable vendor mode, and download all modules.

☝️ I should mention that go mod vendor would already download all modules, so ... perhaps not the worst, but it likely requires changes in the moby integration tests, which assume vendor 🤔

Would look something like;

cd "$GITHUB_WORKSPACE"

go work init ./moby ./extensions

cd moby
GOFLAGS=-mod=readonly make test-integration

-
name: Set up Docker Buildx
uses: docker/setup-buildx-action@f87e5991a6d7451dcb8d9637bfbc97413f497069 # v4.4.1
-
name: Regenerate Moby generated files
working-directory: moby
run: |
make generate-files
# Same paths Moby's generate-files target exports; skips vendoring changes.
# List them first because git add rejects pathspecs that match nothing.
git ls-files -z -m -o --exclude-standard -- ':!vendor' 'profiles/seccomp/default.json' '**/*.pb.go' |
git add --pathspec-from-file=- --pathspec-file-nul
{
echo '### Moby generated-file diff'
if git diff --cached --quiet; then
echo 'Regeneration produced no changes.'
else
echo '```diff'
git diff --cached
echo '```'
fi
} | tee -a "$GITHUB_STEP_SUMMARY"
-
name: Build Moby development image
uses: docker/bake-action@018cb6412ab401ebaa809aa5f85966b74628600f # v7.4.0
with:
source: ./moby
targets: dev
load: true
set: |
dev.cache-from=type=gha,scope=moby-dev-amd64
dev.cache-to=type=gha,scope=moby-dev-amd64,mode=max
-
name: Run Moby extension integration tests
working-directory: moby
env:
TEST_INTEGRATION_DIR: ./integration/extension
TEST_SKIP_INTEGRATION_CLI: "1"
run: make -o build test-integration

success:
runs-on: ubuntu-latest
timeout-minutes: 5
needs:
- validate
- lint
- test
- moby-integration
if: always()
steps:
-
Expand Down
Loading