fix(server): classify structured file MIME types as text#2572
Open
manaskarra wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(server): classify structured file MIME types as text#2572manaskarra wants to merge 1 commit intomodelcontextprotocol:mainfrom
manaskarra wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application/json,application/*+json, XML, YAML, JavaScript, and SVG as text forFileResource.application/octet-streamand explicitis_binary=Trueoverrides.text/*MIME types.Motivation and Context
FileResourcecurrently marks every non-text/*MIME type as binary. That makes common textual resources like JSON files returnbytes, which are then exposed as blob resource contents instead of text resource contents.How Has This Been Tested?
uv run --frozen pytest tests/server/mcpserver/resources/test_file_resources.pyuv run --frozen ruff check src/mcp/server/mcpserver/resources/types.py tests/server/mcpserver/resources/test_file_resources.pygit diff --check