Clarify missing tool_result validation error#3053
Open
HarperZ9 wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_use/tool_resultbalance validation strictValueErrortool_usefollowed by user text instead oftool_resultRelated to #2960. This PR does not relax the balance rule; it only makes the diagnostic distinguish a missing
tool_resultfrom an ID mismatch when atool_useis followed by a non-result message.Tests
uv run --frozen pytest tests/server/test_validation.py -quv run --frozen ruff check src/mcp/server/validation.py tests/server/test_validation.pyuv run --frozen ruff format --check src/mcp/server/validation.py tests/server/test_validation.pygit diff --check