fix(ui): select exact confirmation text on double click - #1544
Open
thedancingdeveloper wants to merge 203 commits into
Open
fix(ui): select exact confirmation text on double click#1544thedancingdeveloper wants to merge 203 commits into
thedancingdeveloper wants to merge 203 commits into
Conversation
…r radius cutting off search input
…ction state after delete
…tech#1528) Git providers send push webhooks for every branch and Komodo filters them server side (docs: Automate > Webhooks > Branch Filtering), so a push to a non-matching branch is routine operation, not a failure. It was surfaced through the generic 'Failed at running webhook' warn, indistinguishable from genuine failures, and a repo with active bot branches (e.g. Renovate) produces hundreds of these warns per day. Rename ExtractBranch::verify_branch to branch_matches, returning Ok(false) on a mismatch (logged at debug) so handlers skip quietly, matching the existing silent webhook_enabled=false skip. Branch EXTRACTION failures (e.g. a ref-less payload on a named-branch listener) still return Err and reach the warn, preserving the misconfiguration signal.
…t corrupt service detection (moghtech#1529) Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Maxwell Becker <49575486+mbecker20@users.noreply.github.com>
…by stats (cpu, mem, disk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confirmTextbelowfrom entering a subsequent manual copymogh_uimodal intactFixes the manual-selection case described in #1383.
Root cause
mogh_uirenders the bold confirmation value adjacent to a text node beginning with a space. Native browser word selection can include that boundary whitespace. Komodo already wraps the shared modal, so this handles double-click at the wrapper boundary without duplicating the dependency component.Testing
cd client/core/ts && corepack yarn install --frozen-lockfile && corepack yarn build && corepack yarn linkcd ui && corepack yarn link komodo_client && corepack yarn install --frozen-lockfile && corepack yarn buildgit diff --checkThe UI production build succeeds. Existing dependency peer warnings and Vite chunk-size warnings are unchanged.