feat(aggregation-stage-icons): add aggregation stage icons package#769
Merged
Conversation
nbbeeken
approved these changes
Jun 1, 2026
addaleax
approved these changes
Jun 1, 2026
gribnoysup
approved these changes
Jun 2, 2026
Collaborator
gribnoysup
left a comment
There was a problem hiding this comment.
Looks good, but wouldn't it make more sense to just have them close to constants so that we know when to add a new one?
Member
Author
|
@gribnoysup I was thinking about adding it there and decided against it just to keep react out of mongodb-constants. I don't feel too strongly so I'm happy moving it there if you'd like. Eventually I think it makes the most sense to be in the design systems. I've asked about that in their slack channel https://mongodb.slack.com/archives/CFFA5BS79/p1780416541946559 |
Collaborator
|
FWIW I don't think we need to package React with it like that, svg paths are already very portable, but no strong opinions on that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having icons in the aggregation stage select options in Compass will help folks find their stages faster and add some visually descriptive information for the stages. I'm opening the pr here instead of Compass as I figure as the icons could be used in another place down the line, like VSCode. If folks feel it's better in Compass let me know! Happy to move it over.
I haven't made an icon react package library before, let me know if there are any suggestions around exporting/typing. Here's LG's icon package as a reference.
This list of icons isn't designed to be an exhaustive list of all of the stages. The consumer will have to have fallbacks for any unsupported stages.
Misba designed these! With some AI assistance along the way.
Here's how it will look in Compass:

All of the icons * some of them have been tweaked since this screenshot was taken
