Skip to content

[Certora] settlement fee spread assumption#989

Open
QGarchery wants to merge 18 commits into
mainfrom
certora-settlement-fee-spread
Open

[Certora] settlement fee spread assumption#989
QGarchery wants to merge 18 commits into
mainfrom
certora-settlement-fee-spread

Conversation

@QGarchery

@QGarchery QGarchery commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Fixes:

Also:

  • removes occurrences of onRatify (now renamed isRatified)
  • make settlementFeeSpread use havoc all by default

corresponding thread

@QGarchery QGarchery self-assigned this Jun 15, 2026
@QGarchery QGarchery linked an issue Jun 15, 2026 that may be closed by this pull request
Comment thread certora/specs/SettlementFeeSpread.spec Outdated
chatgpt-codex-connector[bot]

This comment was marked as low quality.

@jhoenicke jhoenicke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TouchMarketIsCalled looks fine, the rest is just a comment update.

Comment thread certora/specs/SettlementFeeSpread.spec Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14a9491acb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread certora/specs/SettlementFeeSpread.spec Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Certora] side effect of calling settlementFee in a rule

3 participants