Repository navigation
Conversation
…oded strings - modify.nss: the Pin/Unpin, file manage and Terminal groups were matched by hardcoded English names, so with a non-English language the items no longer landed in the (localized) menus. Reference the localized titles instead. - taskbar.nss, goto.nss, file-manage.nss, terminal.nss, develop.nss: replace hardcoded English titles and prompts with loc.* keys (taskbar manager menu, user folders, "Type extension" prompt, run-as-administrator tip, dotnet menu). - en.nss: add the new keys as the fallback values; other languages keep falling back to English for keys they do not define yet. - zh-CN.nss: translate the new keys, use the Windows term for "take ownership" and stop translating "About" as "System info". - Fix the "publish sinale file" typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Several menu strings were still hardcoded in English, so they were not
translated even with a language file loaded. This moves them into the
language files and completes the Simplified Chinese translation.
Bug fix
modify.nssmoved items into groups by their English names(
"Pin/Unpin","file manage","Terminal"), but those menus are titledwith
loc.pin_unpin/loc.file_manage/title.terminal. With anynon-English language the names no longer match, so the items do not end up
in the localized groups. They now reference the localized titles.
Localized
New keys are added to
en.nss. Other languages fall back to English forkeys they do not define (all language files are merged into the same
loctable,
en.nssfirst), and the English values are identical to the stringsthat were hardcoded before, so nothing changes for them.
zh-CN.nsshas the translations. Also fixes the "sinale" typo.Tested
Built from
main(VS 2022, x64 Release) and run on Windows 11 26300 with azh-CN system: the main menus, the taskbar menu and the dotnet submenu show
in Chinese. I did not test other languages; I checked statically that every
loc.*key used in the config is defined inen.nssand that none of thenew key names exist in the other language files.
zh-TW is not touched here (it also needs the new keys and has
windows_defenderset to "Windows Update"); I can send that separately.