Skip to content

Inline the init method in the StructTreeRoot constructor#21505

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:StructTreeRoot-rm-init
Jun 26, 2026
Merged

Inline the init method in the StructTreeRoot constructor#21505
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:StructTreeRoot-rm-init

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Currently the constructor only set various class fields and the class instance thus needs to be "manually" initialized, which seems unnecessary.
Given how short/simple the init and readRoleMap methods are we can just inline their code in the constructor, thus simplifying the code overall.

Currently the constructor only set various class fields and the class instance thus needs to be "manually" initialized, which seems unnecessary.
Given how short/simple the `init` and `readRoleMap` methods are we can just inline their code in the constructor, thus simplifying the code overall.
@codecov-commenter

codecov-commenter commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (86ffd68) to head (8232440).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21505      +/-   ##
==========================================
- Coverage   89.82%   89.80%   -0.03%     
==========================================
  Files         260      260              
  Lines       66274    66267       -7     
==========================================
- Hits        59532    59512      -20     
- Misses       6742     6755      +13     
Flag Coverage Δ
browsertest 66.70% <100.00%> (+0.01%) ⬆️
fonttest 9.03% <ø> (ø)
integrationtest 68.94% <100.00%> (-0.01%) ⬇️
unittest 57.22% <100.00%> (-0.02%) ⬇️
unittestcli 56.20% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/52ec29189a3ad86/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d0686b52f0a67bd/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/52ec29189a3ad86/output.txt

Total script time: 18.11 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/d0686b52f0a67bd/output.txt

Total script time: 25.12 mins

  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 8bdd159 into mozilla:master Jun 26, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you for simplifying this code!

@Snuffleupagus Snuffleupagus deleted the StructTreeRoot-rm-init branch June 26, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants