Inline the init method in the StructTreeRoot constructor#21505
Conversation
Currently the constructor only set various class fields and the class instance thus needs to be "manually" initialized, which seems unnecessary. Given how short/simple the `init` and `readRoleMap` methods are we can just inline their code in the constructor, thus simplifying the code overall.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21505 +/- ##
==========================================
- Coverage 89.82% 89.80% -0.03%
==========================================
Files 260 260
Lines 66274 66267 -7
==========================================
- Hits 59532 59512 -20
- Misses 6742 6755 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/52ec29189a3ad86/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d0686b52f0a67bd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/52ec29189a3ad86/output.txt Total script time: 18.11 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d0686b52f0a67bd/output.txt Total script time: 25.12 mins
|
|
Thank you for simplifying this code! |
Currently the constructor only set various class fields and the class instance thus needs to be "manually" initialized, which seems unnecessary.
Given how short/simple the
initandreadRoleMapmethods are we can just inline their code in the constructor, thus simplifying the code overall.