Repository navigation
channel: enforce remaining receive window - #1518
Open
sankalpsthakur wants to merge 2 commits into
Open
sankalpsthakur wants to merge 2 commits into
sankalpsthakur wants to merge 2 commits into
Conversation
Author
|
Hi, gentle ping on this when someone has a moment. Happy to adjust anything. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1505. Original report by afldl.
Reject channel data exceeding the remaining receive window before subtracting its length or buffering it. Cover client stdout, client stderr and server-side data; preserve the existing behavior of ignoring data when credit is zero.
Bounded regressions cover exact-credit acceptance and over-credit rejection across window sizes 0/1/4 and payload sizes 0/1/4/5. They failed on untouched upstream and pass with this change.
npm run lintpasses.Full
npm testis not green on macOS with Node.js 22.23.2: old-OpenSSH RSA integration exits 255, also reproduced upstream with OpenSSH 10.3, and userauth encountered a localhost timeout. Optional native crypto is absent; unsupported arcfour is skipped.AI tools assisted with implementation, tests and this description.
also flushes writes still waiting on window credit before a deferred close after end(), fixes #1508