Conversation
Bundle size
PerformanceTotal duration: 942.36 ms +18.20 ms(+2.0%) | Renders: 72 (▼-4) | Paint: 1,538.93 ms +60.75 ms(+4.1%)
12 tests within noise — details Metric alarms
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
mnajdova
force-pushed
the
docs/view-transition-demos
branch
2 times, most recently
from
September 17, 2026 10:14
ba5922a to
2a086f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mostly created this to test and see how our components would support
ViewTransition.There are some issues with popups. Closing worked fully, but opening did not animate. Based on Claude it fails because:
Possible fix
would be making the popup's hidden attribute derive from a value that is correct on the opening commit rather than the store's lagging copy. That could mean syncing mounted into the store during render, or having the Popup read mounted from the root through context. Either touches the shared popup store, so it affects all popups and needs more testing. For now, I added the "Popups" note in the Animation handbook, but we could discuss if we want to fix it first..
Two other things:
We can discuss this next week, to wait the minimum package age to pass and the CI to be happy :)