Skip to content

ListItemBlank fix#78

Open
grliszas14 wants to merge 1 commit into
musescore:mainfrom
grliszas14:listitemblank_fix
Open

ListItemBlank fix#78
grliszas14 wants to merge 1 commit into
musescore:mainfrom
grliszas14:listitemblank_fix

Conversation

@grliszas14

Copy link
Copy Markdown
Contributor

Resolves: audacity/audacity#11024

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

@grliszas14 grliszas14 requested a review from Eism June 5, 2026 11:02
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 39d52bd0-ac11-4dd2-be38-c05ce61c9a3e

📥 Commits

Reviewing files that changed from the base of the PR and between b7c0614 and 9177523.

📒 Files selected for processing (1)
  • framework/uicomponents/qml/Muse/UiComponents/ListItemBlank.qml

📝 Walkthrough

Walkthrough

This PR adds a keyboardRemovable boolean property to ListItemBlank.qml that gates keyboard event handling for Delete and Backspace keys. The property defaults to false. When false, the Keys.onShortcutOverride handler early-exits to prevent the component from intercepting those key events. When true, the existing Delete/Backspace behavior remains unchanged. This allows callers to control whether list items respond to keyboard removal requests on a per-instance basis.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'ListItemBlank fix' is vague and does not clearly describe the specific change being made (adding keyboard removability control). Improve the title to be more specific, such as 'Add keyboardRemovable property to ListItemBlank' or similar, to better describe the actual change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The PR description includes the linked issue and checklist, though missing a short description of the motivation and changes being made.
Linked Issues check ✅ Passed The PR adds a keyboardRemovable property to ListItemBlank that allows Delete/Backspace key handling to be controlled, addressing the issue where clicking the Time toolbar prevented delete shortcuts from working.
Out of Scope Changes check ✅ Passed The changes are limited to adding a single boolean property to ListItemBlank.qml to control keyboard removal behavior, which is directly related to the linked issue objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timecode breaks del hotkey

1 participant