Skip to content

refactor: converting from kyper tag to MXUI tag - #378

Merged
wesrisenmay-mx merged 1 commit into
masterfrom
wes/CT-2475/tag
Sep 8, 2026
Merged

refactor: converting from kyper tag to MXUI tag#378
wesrisenmay-mx merged 1 commit into
masterfrom
wes/CT-2475/tag

Conversation

@wesrisenmay-mx

@wesrisenmay-mx wesrisenmay-mx commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Before:
image

After:
image

Unfortunately the text inside the tag is the wrong color. I can't fix that without changing an overridden theme. I'm going to fix that next: https://mxcom.atlassian.net/browse/CT-2550

@jenheinermx

Copy link
Copy Markdown

very close to what is was before which is good. a few things that where off with the before that would be good to fix here:

  1. left alignment is off. can't tell by looking at it if the back button and logos are in the margin space or if the text is indented.

  2. Screenshot 2026-09-08 at 10 43 55 AM
  3. spacing between the logo/icon and the text on the list items is inconsistent. gringotts looks like it has too much space between the logo and text.

Screenshot 2026-09-08 at 10 45 38 AM
  1. the right chevron on the lower list item appear to be larger than 24x24 (should be the same as the manual account screen), and is the primary main color instead of text/primary. not sure why we don't have chevrons on all or none of them, but i'll address that another day.
Screenshot 2026-09-08 at 10 48 04 AM

@wesrisenmay-mx

Copy link
Copy Markdown
Collaborator Author

very close to what is was before which is good. a few things that where off with the before that would be good to fix here:

  1. left alignment is off. can't tell by looking at it if the back button and logos are in the margin space or if the text is indented.
  2. Screenshot 2026-09-08 at 10 43 55 AM
  3. spacing between the logo/icon and the text on the list items is inconsistent. gringotts looks like it has too much space between the logo and text.
Screenshot 2026-09-08 at 10 45 38 AM 4. the right chevron on the lower list item appear to be larger than 24x24 (should be the same as the manual account screen), and is the primary main color instead of text/primary. not sure why we don't have chevrons on all or none of them, but i'll address that another day. Screenshot 2026-09-08 at 10 48 04 AM

As discussed this work is moved to another ticket

@wesrisenmay-mx
wesrisenmay-mx merged commit dfdf3ea into master Sep 8, 2026
7 checks passed
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 2.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants