Skip to content

feat: add name field to ManagedCard model - #392

Merged
tessstoddard merged 1 commit into
masterfrom
tess/managed_card_name
Sep 10, 2026
Merged

feat: add name field to ManagedCard model#392
tessstoddard merged 1 commit into
masterfrom
tess/managed_card_name

Conversation

@tessstoddard

@tessstoddard tessstoddard commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Add name field to ManagedCard model. And cleanup the model to use @Data annotation.

Fixes # https://mxcom.atlassian.net/browse/GCU-1449

Public API Additions/Changes

Added new field to ManagedCard. Spec change here: https://gitlab.com/mxtechnologies/mx/gutenberg/-/merge_requests/979

Downstream Consumer Impact

No downstream impact

How Has This Been Tested?

Used a local snapshot to verify

GET http://localhost:3009/globalcu/users/U-00u3la36x0bbNvPud1d7/managed_cards

HTTP/1.1 200 
Content-Type: application/vnd.mx.mdx.v6+json;charset=UTF-8
Content-Length: 564
Date: Thu, 10 Sep 2026 22:02:41 GMT

{
  "managed_cards": [
    {
      "account_id": "A-1504331-V-1hY6fFt",
      "account_type": "CREDIT",
      "expiration_on_card": "01/30",
      "id": "79662feb46c26a3b705ad45c3d003216d7d5d3b616bdde01385834f46e37a2e5",
      "image_url": "https://public.globalcu.org/images/cards/MARINERS_VISA_CC_LARGE.png",
      "issuance_type": "PHYSICAL",
      "masked_number_on_card": "****2774",
      "name": "Visa Platinum",
      "name_on_card": "MARGARET DICKENS",
      "status": "ENABLED",
      "type": "VISA",
      "user_id": "U-00u3la36x0bbNvPud1d7"
    }
  ]
}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@gerfboy gerfboy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this.

@tessstoddard
tessstoddard merged commit 290396f into master Sep 10, 2026
7 checks passed
@tessstoddard
tessstoddard deleted the tess/managed_card_name branch September 10, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants