update management env vars with NB_PPROF_ADDR#854
Conversation
📝 WalkthroughWalkthroughThe self-hosted environment variable documentation now lists ChangesSelf-hosted runtime documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: one or more packages not found in the registry. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/pages/selfhosted/environment-variables.mdx (1)
133-133: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winClarify the pprof endpoint and exposure risk.
Document that this starts a Go pprof HTTP endpoint, include an address example such as
localhost:6060, and advise restricting externally reachable bindings. The existing client documentation already provides this more actionable description.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/selfhosted/environment-variables.mdx` at line 133, Update the NB_PPROF_ADDR entry in the environment-variable documentation to state that it starts a Go pprof HTTP endpoint, include a localhost:6060 address example, and advise binding only to restricted or non-public interfaces when external exposure is not intended.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/pages/selfhosted/environment-variables.mdx`:
- Line 133: Update the NB_PPROF_ADDR entry in the environment-variable
documentation to state that it starts a Go pprof HTTP endpoint, include a
localhost:6060 address example, and advise binding only to restricted or
non-public interfaces when external exposure is not intended.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5a16defb-ea09-4706-828e-6f3a744a5f67
📒 Files selected for processing (1)
src/pages/selfhosted/environment-variables.mdx
Summary by CodeRabbit
NB_PPROF_ADDRruntime environment variable, including its use for enabling pprof on a specified address.