Handle upsmon NOTIFYCMD and upssched CMDSCRIPT values strictly as paths#3499
Conversation
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 3f1da37 is temporarily available: NUT-tarballs-PR-3499.zip. |
…CRIPT values strictly as paths [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.5.4856-master failed (commit c5afe1a9f4 by @jimklimov) |
…CRIPT values strictly as paths [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.4858-master completed (commit 56e169d096 by @jimklimov)
|
|
✅ Build nut 2.8.5.4858-master completed (commit 56e169d096 by @jimklimov) |
…CRIPT values strictly as paths [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.4896-master completed (commit 9d71ba391a by @jimklimov)
|
|
✅ Build nut 2.8.5.4898-master completed (commit 771863a5c8 by @jimklimov)
|
upsmon, upssched: handle NOTIFYCMD and CMDSCRIPT values strictly as pathsupsmon NOTIFYCMD and upssched CMDSCRIPT values strictly as paths
|
UPDATE: Upon practical review, e.g. per examples in issue #3525 and PR #3527, there may be significant usage of multi-token command lines, such as the interpreter program name ( This PR would break such use-cases, and should be extended to pass through multiple tokens seen by NUT "parseconf" code as separate |
…le command-line args as separately quoted tokens in the directive [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… in upsmon [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ert-related data [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…in one token [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…pstools#3499, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.4927-master completed (commit f4a419731e by @jimklimov)
|
…in one token [networkupstools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…pstools#3499, networkupstools#1711] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ools#3499] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.4930-master completed (commit 62ecd3005d by @jimklimov)
|
|
✅ Build nut 2.8.5.4931-master completed (commit 6a2b4569c3 by @jimklimov)
|
Documentation was vague about this, and implementation used
system()which modern guidelines frown upon. Fix this to mean a single token with an exact path name (or a program inPATH) without arguments, inline scriptlets, etc.NOTE:
SHUTDOWNCMDshould not be impacted by this change, and can still take arguments as is often does (e.g.shutdown -t now).