fix: Remove uses of IServerContainer interface - #1689
Merged
Conversation
CarlSchwan
approved these changes
Sep 10, 2026
come-nc
force-pushed
the
fix/remove-iservercontainer-ref
branch
from
September 10, 2026 13:52
9a69551 to
d22a003
Compare
This deprecated interface will get removed soon. Signed-off-by: C么me Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/remove-iservercontainer-ref
branch
from
September 10, 2026 14:11
d22a003 to
199b980
Compare
come-nc
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help fix CI for nextcloud/server#64095
As this application supports several server version I cannot use
\OC\Serverin DI as it was not registered before 36.This application relies on internal methods to override services so the code cannot be extra-clean.
I decided to use
\OCP\Server::get(ContainerInterface::class)to get the server object.\OC::$serverwould work too.馃 AI (if applicable)