test(files): make FolderTest multi-storage pagination coverage deterministic#61579
Draft
joshtrichards wants to merge 2 commits into
Draft
test(files): make FolderTest multi-storage pagination coverage deterministic#61579joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
- clearer and slightly more robust owner-limited home-folder validation - replace array_map/array_merge with nested foreach loop for better readability, performance, and maintainability - eliminate mixed usage of of $this->getPath() and $this->path for local for path-related checks; introduce local $currentPath for readability/micro-optimization in loop - improve comments around cache merging, filtering, and ordering - skip sorting when the result set has fewer than two items - drop redundant docblock; covered in interface Signed-off-by: Josh <josh.t.richards@gmail.com>
- make multi-storage search pagination test deterministic - split sub-storage pagination coverage by explicit vs default ordering Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes flaky multi-storage search pagination coverage in
FolderTestand adds clearer separation between default-order and explicit-order assertions.Changes:
Folder::search()(originally thought this may be a production code matter)Why:
The previous test mixed two different concerns:
For multi-storage search results, asserting an exact default order across sub-storages was brittle and could fail depending on how file IDs were assigned across caches. The updated tests keep coverage for the default case, but only assert properties that are safe under unspecified ordering, while preserving strict sequence assertions for explicitly ordered queries.
Fixes failures like https://github.com/nextcloud/server/actions/runs/28053658919/job/83050710177?pr=61555
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)