fix(image): honor file path when saving WebP images#61598
Open
joshtrichards wants to merge 1 commit into
Open
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix WebP image saving by passing the requested destination path to
imagewebp().Previously, the WebP branch in
OC\Image::_output()passednullas the target path, which could write the image to output instead of saving it to the requested file.Noticed this in
Image::_output()while perusing the code. While it's almost certainly a bug that breakssave(), admittedly I also can't find any callers ofsave()... but it is part of our public API so at least correcting this as long as the function still exists...server/lib/public/IImage.php
Lines 68 to 75 in ba137f0
Tests pass for
save()because it only impactsWebPimage format specifically, which isn't a format specifically covered.Checklist
3. to review, feature component)stable32)AI (if applicable)